Skip to content

Add ato v2 test when Appsec is disabled #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

@estringana estringana commented May 19, 2025

Motivation

Following ATO SDK Consodillation RFC I realised there were no tests ensuring scenarios with DD_APPSEC_ENABLED=false work as defined

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@estringana estringana force-pushed the estringana/expand-ato-v20-tests branch 2 times, most recently from 818e9b8 to 530c1ad Compare May 20, 2025 07:26
@estringana estringana marked this pull request as ready for review May 22, 2025 10:15
@estringana estringana requested review from a team as code owners May 22, 2025 10:15
@estringana estringana requested review from emmettbutler, lievan, smola and jandro996 and removed request for a team May 22, 2025 10:15
@estringana estringana force-pushed the estringana/expand-ato-v20-tests branch from a5c2728 to 6d70ee1 Compare May 22, 2025 10:16
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few corrections to the descriptions, but I guess it's 👍🏼

@estringana estringana force-pushed the estringana/expand-ato-v20-tests branch 2 times, most recently from d8df133 to e0783dd Compare June 18, 2025 12:57
@@ -967,6 +967,14 @@ class _Scenarios:
scenario_groups=[scenario_groups.appsec],
)

ato_sdk = EndToEndScenario(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use an existing scenario where appsec is disabled ?

@estringana estringana force-pushed the estringana/expand-ato-v20-tests branch from e0783dd to b38f9a9 Compare June 25, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants