-
Notifications
You must be signed in to change notification settings - Fork 14
Add ato v2 test when Appsec is disabled #4668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
estringana
wants to merge
7
commits into
main
Choose a base branch
from
estringana/expand-ato-v20-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
818e9b8
to
530c1ad
Compare
uurien
reviewed
May 20, 2025
a5c2728
to
6d70ee1
Compare
Strech
approved these changes
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few corrections to the descriptions, but I guess it's 👍🏼
7 tasks
d8df133
to
e0783dd
Compare
cbeauchesne
reviewed
Jun 18, 2025
@@ -967,6 +967,14 @@ class _Scenarios: | |||
scenario_groups=[scenario_groups.appsec], | |||
) | |||
|
|||
ato_sdk = EndToEndScenario( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use an existing scenario where appsec is disabled ?
Co-authored-by: Sergey Fedorov <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
e0783dd
to
b38f9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following ATO SDK Consodillation RFC I realised there were no tests ensuring scenarios with
DD_APPSEC_ENABLED=false
work as definedChanges
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present