Skip to content

[nodejs] fastify path params tests #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Jun 16, 2025

Motivation

Enable fastify path params tests

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@IlyasShabi IlyasShabi changed the title [Nodejs@ishabi/fastify-path-params] fastify path params tests [nodejs@ishabi/fastify-path-params] fastify path params tests Jun 16, 2025
@IlyasShabi IlyasShabi force-pushed the ishabi/fastify-path-params branch from c076519 to ef1bc55 Compare June 16, 2025 09:39
@IlyasShabi IlyasShabi force-pushed the ishabi/fastify-path-params branch from ebc6438 to 065e444 Compare June 16, 2025 12:54
@IlyasShabi IlyasShabi changed the title [nodejs@ishabi/fastify-path-params] fastify path params tests [nodejs] fastify path params tests Jun 18, 2025
@IlyasShabi IlyasShabi marked this pull request as ready for review June 18, 2025 11:18
@IlyasShabi IlyasShabi requested a review from a team as a code owner June 18, 2025 11:18
@IlyasShabi IlyasShabi merged commit f9ee184 into main Jun 18, 2025
45 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/fastify-path-params branch June 18, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants