Fix delimiter parsing #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@droyad, can you please review this PR, i cannot use the last prerelease with scripts generated by efcore. |
|
Hello, |
droyad
approved these changes
Mar 3, 2025
1 task
droyad
added a commit
that referenced
this pull request
Mar 3, 2025
* Add NpgsqlDataSource support to PostgresqlConnectionManager * Used new GHA workflows * Updated to dbup-core 6.0 beta, targeted netstandard2 and update Npgsql reference * Bump to the next beta of dbup-core * Merge fix * Removed stray #If * fix: #680 PostgreSQL statements split implemented (#19) * fix: #680 PostgreSQL statements split implemented Co-authored-by: shokurov <[email protected]> * Updated approval file --------- Co-authored-by: shokurov <[email protected]> Co-authored-by: Robert Wagner <[email protected]> * Update of libs * File scoped namespaces and primary ctors * Target `net8` so we can use the latest version of Npgsql (#24) * Target net8 so we can use the latest version of Npgsql * Used new APIs * Added Npgsql licence information (#25) * fix(#26): avoid NullReferenceException when creating database (#27) * fix(#26): avoid NullReferenceException when creating database * Updated approval file --------- Co-authored-by: Robert Wagner <[email protected]> * fix: fix delimiter parsing (#28) * Lowered Connection string printing to debug, resolves #30 --------- Co-authored-by: Sébastien Crocquesel <[email protected]> Co-authored-by: Campbell Harding-Deason <[email protected]> Co-authored-by: shokurov <[email protected]> Co-authored-by: nvierge-addactis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
SQL scripts are not correctly parsed into commands when there are delimiters.
Scripts generated by EF Core do not work correctly.
IndexOf return a position that is already relative to the entire string.
Close #29