Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a bunch of small refactors and optimizations, but major change is pulling dimension fee breakdown (by custom label) and exposing it via api:
types.ts
cron/dimensions.ts
to make the file look (little) less daunting, added more commentsaggregated
from dimensions record withaggObject
, I had a good reason, but cant recall why now, think I probably tried to remove it, but realized that if record contains non dataType fields, makes bit more of of a pain to iterate, right now, we know that all keys in aggObject are dataType (like dailyFees, dailyRevenue, etc)What is missing/needs to be fixed: