Reorganise libs #34
Merged
Reorganise libs #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into their corresponding libs
marinPh
approved these changes
Sep 29, 2024
LoRa4Raspi/CMakeLists.txt
Outdated
Comment on lines
1
to
9
| set(LORA_SOURCES src/LoRa.cpp | ||
| src/itoa.cpp | ||
| src/LoopbackStream.cpp | ||
| src/Print.cpp | ||
| src/Stream.cpp | ||
| src/WString.cpp) | ||
| add_library(LoRa4Raspi ${LORA_SOURCES}) | ||
| target_include_directories(LoRa4Raspi PUBLIC include) | ||
| target_link_libraries(LoRa4Raspi PUBLIC pigpio) |
There was a problem hiding this comment.
much better use of library creation
…ase (flight_computer)
marinPh
approved these changes
Oct 4, 2024
Comment on lines
+10
to
+20
| set(FIREHORN_FC_SOURCES | ||
| ${DATA_DIR}/data.cpp | ||
| ${DATA_DIR}/data.h | ||
| ${DATA_DIR}/sensors.cpp | ||
| ${DATA_DIR}/sensors.h | ||
| ${DATA_DIR}/telecom.cpp | ||
| ${DATA_DIR}/telecom.h | ||
|
|
||
| ${FLIGHT_CONTROL_DIR}/av_state.cpp | ||
| ${FLIGHT_CONTROL_DIR}/av_state.h | ||
| ${FLIGHT_CONTROL_DIR}/thresholds.h |
There was a problem hiding this comment.
thats a much more efficient way of compiling the FC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just about redefining what we consider a library or not in our source files. I don't think creating a static library for each single cxx file is a good idea. Static libraries are meant to regroup several files that share one purpose. So I grouped each module into a library, and like that no need to relink each single "atomic" lib to a test executable. If a test file uses adxl375.cpp, just link with libadxl375.