Support for changed game constants: StatDelimiter & WhiteDragon patches #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mespace "Player::Constants"
…ch is to be used by the engine detection (EasyRPG#3166)
…ne_File & Scene_Save
…atDelimiter" patches from experimental branch "PlayerLimits"
…s in Vanilla RPG_RT)
github-actions
bot
added
Window/Scenes
Battle
Tests
Settings
fdelapena
added
the
Awaiting Rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly picked from PR #3352, with some rebasing & movement of code.
This version has no support for reading individual patched constants from RPG_RT code addresses but is able to heuristically detect both the Italian "WhiteDragon" version of RPG_RT & several variants of the "StatDelimiter" patch. (https://dev.makerpendium.de/docs/patch_db/main-en.htm?page=stat_delimiter)
This also doesn't include the Battle Stat Split mentioned in the previous PR.
Plus, for added support, the upper limits for Enemy HP/SP have been removed completely, as those limitations applied only to the RPG Maker's editor & the values could actually be extended to the upper limit of signed integer values.
But: If easyrpg_max_enemy_hp or easyrpg_max_enemy_sp are defined in the LDB then those changed limits will still take effect!
Starting the Player with custom runtime versions
To make it easier to test this feature, I also implemented a new command argument "--engine-path" (See Issue #3166 )
Usage:
Player.exe --test-play --engine-path RT_rm2k3_advo_108_en.dat