added persisntent bottom nav bar #2060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo.webm |
21 tasks
- Changed default value of useRoot from false to true in ShowDialogAction. - Removed unnecessary print statements and cleaned up exception handling in dialog actions. - Removed commented-out code related to bottom navigation visibility in PageState for clarity.
- Introduced a new boolean parameter `useRoot` with a default value of true in ShowBottomSheetAction to control the use of the root navigator. - Updated the ShowDialogAction to ensure consistent behavior by setting a default value for `useRoot` and removing nullable handling.
sharjeelyunus
previously approved these changes
Aug 26, 2025
… imports - Improved screen navigation logic to default to replacing the current screen when navigating to a ViewGroup without an explicit route option. - Updated the navigator usage to ensure proper handling of nested navigators. - Cleaned up unused imports and commented-out code in screen_controller.dart and bottom_nav_page_group.dart for better readability. - Simplified bottom navigation visibility logic in page.dart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new keyword showMenu to show an existing bottom nav bar on any page (View). You will have to set showMenu to true in View styles. By default its value is false.
Sample Usage