Skip to content

Conversation

sgasho
Copy link

@sgasho sgasho commented Aug 31, 2025

closes: #2429
related: rust-lang/rust#145899

result of act dry-run

act -n -W .github/workflows/enzyme-rust.yml -P self-hosted=ubuntu-latest -P Linux=ubuntu-latest -P X64=ubuntu-latest -P 32-core=ubuntu-latest
INFO[0000] Using docker host 'unix:///var/run/docker.sock', and daemon socket 'unix:///var/run/docker.sock' 
WARN  ⚠ You are using Apple M-series chip and you have not specified container architecture, you might encounter issues while running act. If so, try running it with '--container-architecture linux/amd64'. ⚠  
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Set up job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] 🚀  Start image=ubuntu-latest
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Set up job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] 🚀  Start image=ubuntu-latest
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   🐳  docker pull image=ubuntu-latest platform= username= forcePull=true
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   🐳  docker pull image=ubuntu-latest platform= username= forcePull=true
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   🐳  docker create image=ubuntu-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   🐳  docker run image=ubuntu-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Set up job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   🐳  docker create image=ubuntu-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   🐳  docker run image=ubuntu-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Set up job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] 🧪  Matrix: map[llvm:19]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] 🧪  Matrix: map[llvm:20]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Install LLVM and dependencies
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Install LLVM and dependencies
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Install LLVM and dependencies [3.041958ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Install LLVM and dependencies [3.560292ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Install Rust toolchain
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Install Rust toolchain
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Install Rust toolchain [2.436583ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Install Rust toolchain [2.396541ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Checkout Enzyme
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Checkout Enzyme
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Checkout Enzyme [1.037666ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Checkout Enzyme [1.382292ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Build Enzyme
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Build Enzyme
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Build Enzyme [2.28875ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Build Enzyme [2.499958ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Clone and configure Rust compiler
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Clone and configure Rust compiler
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Clone and configure Rust compiler [2.189917ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Clone and configure Rust compiler [2.093583ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Build Rust compiler stage 1
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Build Rust compiler stage 1
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Build Rust compiler stage 1 [2.484125ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Build Rust compiler stage 1 [2.589625ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Main Run Rust autodiff tests
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Main Run Rust autodiff tests
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Main Run Rust autodiff tests [2.293625ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] ⭐ Run Complete job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] Cleaning up container for job Rust Autodiff Tests LLVM 20
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Main Run Rust autodiff tests [2.496792ms]
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] ⭐ Run Complete job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] Cleaning up container for job Rust Autodiff Tests LLVM 19
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1]   ✅  Success - Complete job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 19-1] 🏁  Job succeeded
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2]   ✅  Success - Complete job
*DRYRUN* [Enzyme Rust CI/Rust Autodiff Tests LLVM 20-2] 🏁  Job succeeded

run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source ~/.cargo/env
rustup toolchain install nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until Rust adds CI for Enzyme, I think this should be fixed to a specific commit

jobs:
rust-autodiff:
name: Rust Autodiff Tests LLVM ${{ matrix.llvm }}
runs-on: [self-hosted, Linux, X64, 32-core]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the correct setup for the runner, see https://github.com/EnzymeAD/Enzyme/blob/main/.github/workflows/enzyme-mlir.yml for an example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to run on linux-x86-n2-32

cmake ../enzyme -DLLVM_EXTERNAL_LIT=`which lit` -DCMAKE_BUILD_TYPE=Release -DLLVM_DIR=/usr/lib/llvm-${{ matrix.llvm }}/lib/cmake/llvm
make -j `nproc` LLVMEnzyme-${{ matrix.llvm }}
- name: Clone and configure Rust compiler
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is never told to use the enzyme we built above?

source ~/.cargo/env
git clone --depth 1 --branch master https://github.com/rust-lang/rust.git
cd rust
./configure --enable-llvm-link-shared --enable-llvm-plugins --enable-llvm-enzyme --release-channel=nightly --enable-llvm-assertions --enable-clang --enable-lld --enable-option-checking --enable-ninja --disable-docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also use ccache here, and cache intermediate artifacts

@sgasho
Copy link
Author

sgasho commented Sep 1, 2025

@wsmoses @ZuseZ4
Thank you so much for the review!
However, I'm sorry for being a beginner at GitHub Actions and Enzyme and I'm not sure how to properly fix about some comments, especially

#2430 (comment)
#2430 (comment)
#2430 (comment)

Could you give me some hints, examples, suggestions, or something I should study?
I did some commits, but I'm not confident, especially wip

@wsmoses
Copy link
Member

wsmoses commented Sep 2, 2025

@ZuseZ4 can you help @sgasho understand the next steps from the comments?

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Sep 2, 2025

I have no experience with ccache and to me it sounds like something that should be added in a follow-up pr to avoid feature creep. But it looks like you've already added it in your last commit? If it works I guess it should stay.

For the pinning of the version, I would assume we want to fix the rustc we build, and not necessarily the rust version we use to build rustc. It's fine to do both, but right now you only pin the version used to build. You should also check out a specific commit of github.com/rust-lang/rust instead of just the master branch. This way, we can verify that new Enzyme versions don't break support. We would update the rustc commit every once in a while. This way, an update to rustc can't break Enzyme CI.

I don't know whats the relevant difference between your. yml file and the mlir example given, so I'd leave that for Billy to answer.

Comment on lines 60 to 61
echo "CC=ccache gcc" >> $GITHUB_ENV
echo "CXX=ccache g++" >> $GITHUB_ENV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who uses this? What exactly is built using GCC? I think Rust still uses LLVM. The rust invocation will prefix its invocations with ccache by itself as far as I can see, thanks to the --enable-ccache a few lines above.

run: |
. ~/.cargo/env
rm -rf build && mkdir build && cd build
RUST_LLVM_DIR=${GITHUB_WORKSPACE}/rust/build/x86_64-unknown-linux-gnu/llvm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would shell-quote this. GitHub probably has no space or special chars in the checkout dir, but better be safe.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shell-quoted it in this commit!
use quotes

run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
. ~/.cargo/env
# Pin to specific nightly commit for reproducibility

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for? Rustc bootstrap? Might be worth it to add a comment saying what is now reproducible. Enzyme itself is built against the latest rust compiler (you check out the main branch of rust-lang/rust), so I imagine it won't really help there?


container:
image: ${{ (contains(matrix.os, 'linux') && 'ghcr.io/enzymead/reactant-docker-images@sha256:91e1edb7a7c869d5a70db06e417f22907be0e67ca86641d48adcea221fedc674' ) || '' }}
image: ${{ (contains(matrix.os, 'linux') && 'ghcr.io/enzymead/reactant-docker-images:main' ) || '' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the specific hash, not main

- name: Install dependencies
run: |
apt-get update
apt-get install -y binutils ninja-build cmake gcc g++ python3 python3-dev ccache nodejs npm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need all these deps?

. ~/.cargo/env
git clone https://github.com/rust-lang/rust.git
cd rust
git checkout 51ff895062ba60a7cba53f57af928c3fb7b0f2f4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move the commit to the matrix? that'll make it easier to update, and or if in the future we want to checkout multiple and/or stable tags

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Sep 5, 2025

This currently builds Enzyme twice, once as part of rustc and once standalone.
Unfortunately it uses the old one from rustc for testing.
Is there a way to delete the default Enzyme submodule and re-add it using the new Enzyme source code which we have here (e.g. through ln -s or copying)? Then you can stop to build it seperately and we use the normal rust infra for building it.

- name: Clone and configure Rust compiler
run: |
. ~/.cargo/env
git clone https://github.com/rust-lang/rust.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use another actions/checkout for this [and can give it the relevant tag/commit]

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Sep 10, 2025

@wsmoses this looks ready? Can you run CI, I don't have permission

@ZuseZ4 ZuseZ4 requested a review from wsmoses September 20, 2025 22:25
--enable-clang \
--enable-lld \
--disable-optimize-llvm \
--enable-option-checking \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the github actions cache here, but lets see if it builds first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise ccache doesn't do anything as the run is ephemeral

@wsmoses
Copy link
Member

wsmoses commented Sep 20, 2025

fails

CMAKE_TOOLCHAIN_FILE_x86_64-unknown-linux-gnu = None
CMAKE_TOOLCHAIN_FILE_x86_64_unknown_linux_gnu = None
HOST_CMAKE_TOOLCHAIN_FILE = None
CMAKE_TOOLCHAIN_FILE = None
CMAKE_PREFIX_PATH_x86_64-unknown-linux-gnu = None
CMAKE_PREFIX_PATH_x86_64_unknown_linux_gnu = None
HOST_CMAKE_PREFIX_PATH = None
CMAKE_PREFIX_PATH = None
CMAKE_x86_64-unknown-linux-gnu = None
CMAKE_x86_64_unknown_linux_gnu = None
HOST_CMAKE = None
CMAKE = None
running: cd "/__w/Enzyme/Enzyme/rust/build/x86_64-unknown-linux-gnu/enzyme/build" && CMAKE_PREFIX_PATH="" DESTDIR="" LC_ALL="C" LLVM_CONFIG_REAL="/__w/Enzyme/Enzyme/rust/build/x86_64-unknown-linux-gnu/llvm/bin/llvm-config" "cmake" "/__w/Enzyme/Enzyme/rust/src/tools/enzyme/enzyme/" "-G" "Ninja" "-DCMAKE_INSTALL_MESSAGE=LAZY" "-DCMAKE_C_COMPILER_LAUNCHER=ccache" "-DCMAKE_CXX_COMPILER_LAUNCHER=ccache" "-DCMAKE_C_COMPILER=cc" "-DCMAKE_CXX_COMPILER=c++" "-DCMAKE_ASM_COMPILER=cc" "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_FLAGS=-ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_SHARED_LINKER_FLAGS=" "-DCMAKE_MODULE_LINKER_FLAGS=" "-DCMAKE_EXE_LINKER_FLAGS=" "-DLLVM_ENABLE_ASSERTIONS=ON" "-DENZYME_EXTERNAL_SHARED_LIB=ON" "-DENZYME_BC_LOADER=OFF" "-DLLVM_DIR=/__w/Enzyme/Enzyme/rust/build/x86_64-unknown-linux-gnu/llvm" "-DCMAKE_INSTALL_PREFIX=/__w/Enzyme/Enzyme/rust/build/x86_64-unknown-linux-gnu/enzyme" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_BUILD_TYPE=Debug"
CMake Error: The source directory "/__w/Enzyme/Enzyme/rust/src/tools/enzyme/enzyme" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.

thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cmake-0.1.54/src/lib.rs:1119:5:

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Sep 26, 2025

@sgasho Not sure if it's related, or needed but you can also try to do a submodule update for enzyme and commit it.

@wsmoses
Copy link
Member

wsmoses commented Sep 26, 2025

Run source ~/.cargo/env
Run '/home/runner/k8s/index.js'
using script executor
/__w/_temp/4f4ab6b8-84af-4b9c-8304-d6f25cfb5572.sh: 1: source: not found
Error: Error: ScriptExecutorError when trying to execute: "Error: Job failed with exit code 127."
Error: Process completed with exit code 1.
Error: Executing the custom container implementation failed. Please contact your self hosted runner admini

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Oct 1, 2025

@sgasho Looks like you managed it! The last test is failing, but that one frequently changes the IR generated, not sure if it's because of rustc, LLVM, or Enzyme changing. I'll look into making it more robust, it's not like that feature (batching) is well tested in Rust atm anyway.

From my side that sounds like it's good to merge?

Also side note, we'll probably switch from linking against Enzyme to just dlopen'ing Enzyme, which should make this CI even simpler in the future: rust-lang/rust#146623

@wsmoses
Copy link
Member

wsmoses commented Oct 1, 2025

while @ZuseZ4 fixes the last test to pass, @sgasho can you get the ccache stuff working?

I think those are the last two things in order to merge!

Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
…youxu

bless autodiff batching test

This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430
Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default.
In the near future we also hope to enable std::autodiff in the Rust CI.

This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes.

r? compiler
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
…youxu

bless autodiff batching test

This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430
Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default.
In the near future we also hope to enable std::autodiff in the Rust CI.

This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes.

r? compiler
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 4, 2025
…youxu

bless autodiff batching test

This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430
Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default.
In the near future we also hope to enable std::autodiff in the Rust CI.

This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes.

r? compiler
@sgasho sgasho requested a review from wsmoses October 4, 2025 14:12
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 4, 2025
…youxu

bless autodiff batching test

This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430
Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default.
In the near future we also hope to enable std::autodiff in the Rust CI.

This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes.

r? compiler
uses: actions/cache@v4
with:
path: ~/.cache/ccache
key: ccache-${{ matrix.os }}-${{ matrix.commit }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also include rust here?

rust-timer added a commit to rust-lang/rust that referenced this pull request Oct 4, 2025
Rollup merge of #147315 - ZuseZ4:fix-ad-batching-test, r=jieyouxu

bless autodiff batching test

This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430
Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default.
In the near future we also hope to enable std::autodiff in the Rust CI.

This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes.

r? compiler
@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Oct 4, 2025

I blessed the last Rust test, so now rust CI should pass if rerun.

@wsmoses
Copy link
Member

wsmoses commented Oct 4, 2025

Or rather if the commit is updated, presumably.

The test shouldn't pull main but a fixed commit

@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Oct 5, 2025

That's unlucky, another update just changed a function hash in a test case. I added another fix on the Rust side to make the test more robust, it should land in a few hrs: rust-lang/rust#147364 (comment)

Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
…eyouxu

update autodiff testcases

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
…eyouxu

update autodiff testcases

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler
rust-timer added a commit to rust-lang/rust that referenced this pull request Oct 5, 2025
Rollup merge of #147364 - ZuseZ4:update-autodiff-tests, r=jieyouxu

update autodiff testcases

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler
@ZuseZ4
Copy link
Collaborator

ZuseZ4 commented Oct 5, 2025

@sgasho the fix landed, so if you update the rust commit it should pass now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to test Rust std::autodiff
4 participants