Fix travis-ci tests #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Oct 31, 2017
| stdlib: | ||
| repo: 'git://github.com/puppetlabs/puppetlabs-stdlib.git' |
There was a problem hiding this comment.
suggest using https with github as its more likely allowed behind corp firewalls
fixtures:
repositories:
stdlib:
repo: 'https://github.com/puppetlabs/puppetlabs-stdlib.git'
ref: '4.6.0'
symlinks:
cgroups: "#{source_dir}"There was a problem hiding this comment.
I find using forge links a bit easier especially when tracking particular versions.
ghoneycutt
reviewed
Oct 31, 2017
| @@ -31,10 +31,6 @@ | |||
| ], | |||
| "requirements": [ | |||
| { | |||
| "name": "pe", | |||
|
Thanks guys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the tests haven't been run for a while and are failing in #18
This is an attempt to get those working again.