Fix bug in calculation of the closest normal direction. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We compare absolute values, but then store the plain value as the current max. This breaks in the case where the closest off is a negative dot product, but is overridden by a subsequent, smaller positive dot product. How did I find this? Well it apparently happened enough times in game for me to notice that the arrow was often pointing in the wrong direction.
|
@qqrz997 to take a look. FWIW I have been using this patch for the last couple of days in my own game. So it nominally works (and removes the randomly pointing arrows). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compare absolute values, but then store the plain value as the current max. This breaks in the case where the closest off is a negative dot product, but is overridden by a subsequent, smaller positive dot product.
How did I find this? Well it apparently happened enough times in game for me to notice that the arrow was often pointing in the wrong direction.
(I've not tested this, but if you want me to let me know how)