Skip to content

Implement email notifications unsubscribe #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Implement email notifications unsubscribe #892

wants to merge 5 commits into from

Conversation

hrvojevu
Copy link
Contributor

@hrvojevu hrvojevu commented Jun 15, 2021 •
edited
Loading

This PR:

  • updates user model with new JSONB notifications column which contains user notification preferences
  • updates user settings form to support comment and assignment notification subscription
    Screen Shot 2021-06-15 at 3 07 05 PM
  • updates comment after create hook to check which users have comment notifications enabled
  • updates activity status hooks to check if user has assignee notifications disabled before sending notification
  • updates comment and assignee email notification templates to include profile page link
    Screen Shot 2021-06-16 at 2 25 04 PM

Screen Shot 2021-06-16 at 2 24 13 PM

@hrvojevu hrvojevu requested a review from 2Pacalypse- June 16, 2021 12:26
@hrvojevu hrvojevu added 👈 needs code review Code review label 🔍 needs QA Quality assurance needed and removed 👈 needs code review Code review label labels Jun 16, 2021
@hrvojevu hrvojevu mentioned this pull request Jun 16, 2021
Closed
4 tasks
2Pacalypse-
2Pacalypse- reviewed Jun 16, 2021
View reviewed changes
@bubafinder bubafinder added 🚧 work in progress and removed 🔍 needs QA Quality assurance needed labels Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@2Pacalypse- 2Pacalypse- 2Pacalypse- left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🚧 work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrvojevu @2Pacalypse- @bubafinder