Skip to content

Switch to vtk version that supports aarch64 wheels in end user image #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

schnellerhase
Copy link
Contributor

@schnellerhase schnellerhase commented Jul 15, 2025

vtk distributed wheels for aarch64 from version 9.5.0 onwards. This allows to switch back to pip installed dependencies for the lab image.

@jhale
Copy link
Member

jhale commented Jul 15, 2025

Let me know when this is ready and I can trigger a build for you.

@jhale
Copy link
Member

jhale commented Jul 15, 2025

Could you simply lower bound the version which you know has arm wheels? Then we can forget about it.

@schnellerhase
Copy link
Contributor Author

Let me know when this is ready and I can trigger a build for you.

Sounds good, lets give it a try.

@schnellerhase
Copy link
Contributor Author

Could you simply lower bound the version which you know has arm wheels? Then we can forget about it.

Then we should probably remove the version pin of pyvista as well, is that fine?

@jhale
Copy link
Member

jhale commented Jul 15, 2025

Yes, should be fine, I think it's pretty stable now.

@francesco-ballarin
Copy link
Member

Please wait for pyvista/pyvista#7690 to be merged and released before triggering a docker image rebuild, because the current pyvista version is not compatible with the newest vtk.

@schnellerhase
Copy link
Contributor Author

Current test run has a 'test' prefix - should not overwrite the images.

Should we then add 0.46 as a pyvista lower bound as well?

@schnellerhase
Copy link
Contributor Author

Running import pyvista in the current container indeed breaks. Installing pyvista 0.46.dev0 (from main) works fine. Let's wait for the release.

@francesco-ballarin
Copy link
Member

Should we then add 0.46 as a pyvista lower bound as well?

Don't think so. pyvista 0.45 (and possibly even lower) is still compatible with main, so anyone on amd64 arch would be able to use it successfully.

@jhale
Copy link
Member

jhale commented Jul 16, 2025

Reviewed and looks good - please merge once pyvista make a new release. There is only a need for a lower bound on vtk.

@francesco-ballarin
Copy link
Member

There is only a need for a lower bound on vtk.

I don't think so. amd64 people can still use whatever vtk version is supported by pyvista, can't they? Linux aarch64 build will implicitly have a >=9.5.0, simply because no support existed before that version.

@jhale
Copy link
Member

jhale commented Jul 16, 2025

Quite possibly, as long as there are no source distributions for any version? Given that we're talking about something which is really an implementation detail, the explicit lower bound might still be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants