fix: Properly mount DOMElement #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOMElements are components, therefore it should be able to instantiate them in an isolated fashion and then add them at a later point in time using `Node#addComponent`.
alexanderGugel
force-pushed
the
DOMElement-component
branch
from
94d3965 to
9367541
Compare
|
Build on Travis CI failed again because of Couldn't reproduce on my local machine. This seems to be a pretty weird test case. while tape ./webgl-geometries/test/*.js; do ; done |
|
Overall I like but have a few issues with the implementation. Will comment inline |
|
@michaelobriena Did you have a change to add the inline comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMElements are components, therefore it should be able to instantiate them in
an isolated fashion and then add them at a later point in time using
Node#addComponent.Other issues this PR addresses:
onShowis being invoked_This is the beginning of a general refactor of some parts of the platform.