Use Flow.Launcher.Localization to improve code quality

.github/actions/spelling/allow.txt

@@ -4,4 +4,8 @@ ssh
 ubuntu
 runcount
 Firefox
+Português
+Português (Brasil)
+favicons
+moz
 workaround

.github/actions/spelling/patterns.txt

@@ -124,6 +124,10 @@
 # version suffix <word>v#
 (?:(?<=[A-Z]{2})V|(?<=[a-z]{2}|[A-Z]{2})v)\d+(?:\b|(?=[a-zA-Z_]))
 
+# Non-English
+[a-zA-Z]*[ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3}[a-zA-ZÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]*
+
+
 \bjjw24\b
 \bappref-ms\b
 \bTobiasSekan\b
@@ -143,3 +147,4 @@
 \bXing\s*Kong\s*Jian\s*Dao\b
 \bDa\s*Niu\b
 \bXiao\s*Lang\b
+\b[Ss]ettings [Ss]ettings\b

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -45,7 +45,7 @@ protected List<Bookmark> LoadBookmarks(string browserDataPath, string name)
             }
             catch (Exception ex)
             {
-                Main._context.API.LogException(ClassName, $"Failed to register bookmark file monitoring: {bookmarkPath}", ex);
+                Main.Context.API.LogException(ClassName, $"Failed to register bookmark file monitoring: {bookmarkPath}", ex);
                 continue;
             }
 
@@ -58,7 +58,7 @@ protected List<Bookmark> LoadBookmarks(string browserDataPath, string name)
                 var faviconDbPath = Path.Combine(profile, "Favicons");
                 if (File.Exists(faviconDbPath))
                 {
-                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {profileBookmarks.Count} favicons cost", () =>
+                    Main.Context.API.StopwatchLogInfo(ClassName, $"Load {profileBookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, profileBookmarks);
                     });
@@ -125,7 +125,7 @@ private static void EnumerateFolderBookmark(JsonElement folderElement, ICollecti
             }
             else
             {
-                Main._context.API.LogError(ClassName, $"type property not found for {subElement.GetString()}");
+                Main.Context.API.LogError(ClassName, $"type property not found for {subElement.GetString()}");
             }
         }
     }
@@ -190,7 +190,7 @@ ORDER BY b.width DESC
                 }
                 catch (Exception ex)
                 {
-                    Main._context.API.LogException(ClassName, $"Failed to extract bookmark favicon: {bookmark.Url}", ex);
+                    Main.Context.API.LogException(ClassName, $"Failed to extract bookmark favicon: {bookmark.Url}", ex);
                 }
                 finally
                 {

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Commands/BookmarkLoader.cs

@@ -9,11 +9,11 @@ internal static class BookmarkLoader
 {
     internal static MatchResult MatchProgram(Bookmark bookmark, string queryString)
     {
-        var match = Main._context.API.FuzzySearch(queryString, bookmark.Name);
+        var match = Main.Context.API.FuzzySearch(queryString, bookmark.Name);
         if (match.IsSearchPrecisionScoreMet())
             return match;
 
-        return Main._context.API.FuzzySearch(queryString, bookmark.Url);
+        return Main.Context.API.FuzzySearch(queryString, bookmark.Url);
     }
 
     internal static List<Bookmark> LoadAllBookmarks(Settings setting)

Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

@@ -49,7 +49,7 @@
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to register Firefox bookmark file monitoring: {placesPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to register Firefox bookmark file monitoring: {placesPath}", ex);
             return bookmarks;
         }
 
@@ -84,7 +84,7 @@
                 var faviconDbPath = Path.Combine(Path.GetDirectoryName(placesPath), "favicons.sqlite");
                 if (File.Exists(faviconDbPath))
                 {
-                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {bookmarks.Count} favicons cost", () =>
+                    Main.Context.API.StopwatchLogInfo(ClassName, $"Load {bookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, bookmarks);
                     });
@@ -98,7 +98,7 @@
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to load Firefox bookmarks: {placesPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to load Firefox bookmarks: {placesPath}", ex);
         }
 
         // Delete temporary file
@@ -111,7 +111,7 @@
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex);
         }
 
         return bookmarks;
@@ -186,7 +186,7 @@
                 }
                 catch (Exception ex)
                 {
-                    Main._context.API.LogException(ClassName, $"Failed to extract Firefox favicon: {bookmark.Url}", ex);
+                    Main.Context.API.LogException(ClassName, $"Failed to extract Firefox favicon: {bookmark.Url}", ex);
                 }
                 finally
                 {
@@ -232,7 +232,7 @@
     /// E.g. C:\Users\{UserName}\AppData\Local\Packages\Mozilla.Firefox_n80bbvh6b1yt2\LocalCache\Roaming\Mozilla\Firefox
     /// <see href="https://support.mozilla.org/en-US/kb/profiles-where-firefox-stores-user-data#w_finding-your-profile-without-opening-firefox"/>
     /// </summary>
     public static string MsixPlacesPath
     {
         get
         {
@@ -244,7 +244,7 @@
                 var firefoxPackageFolder = Directory.EnumerateDirectories(packagesPath, "Mozilla.Firefox*",
                     SearchOption.TopDirectoryOnly).FirstOrDefault();
 
                 // Msix FireFox not installed
                 if (firefoxPackageFolder == null) return string.Empty;
 
                 var profileFolderPath = Path.Combine(firefoxPackageFolder, @"LocalCache\Roaming\Mozilla\Firefox");
@@ -288,7 +288,7 @@
             [Profile2]
             Name=dummyprofile
             IsRelative=0
             Path=C:\t6h2yuq8.dummyprofile  <== Note this is a custom location path for the profile user can set, we need to cater for this in code.
 
             [Profile1]
             Name=default

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj

@@ -81,7 +81,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\Flow.Launcher.Infrastructure\Flow.Launcher.Infrastructure.csproj" />
     <ProjectReference Include="..\..\Flow.Launcher.Plugin\Flow.Launcher.Plugin.csproj" />
   </ItemGroup>
 
@@ -96,6 +95,7 @@
 
   <ItemGroup>
     <PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0" />
+    <PackageReference Include="Flow.Launcher.Localization" Version="0.0.3" />
     <PackageReference Include="Microsoft.Data.Sqlite" Version="9.0.3" />
   </ItemGroup>
 

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Helper/FaviconHelper.cs

@@ -27,9 +27,9 @@ public static void LoadFaviconsFromDb(string faviconCacheDir, string dbPath, Act
             }
             catch (Exception ex1)
             {
-                Main._context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex1);
+                Main.Context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex1);
             }
-            Main._context.API.LogException(ClassName, $"Failed to copy favicon DB: {dbPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to copy favicon DB: {dbPath}", ex);
             return;
         }
 
@@ -39,7 +39,7 @@ public static void LoadFaviconsFromDb(string faviconCacheDir, string dbPath, Act
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to connect to SQLite: {tempDbPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to connect to SQLite: {tempDbPath}", ex);
         }
 
         // Delete temporary file
@@ -49,7 +49,7 @@ public static void LoadFaviconsFromDb(string faviconCacheDir, string dbPath, Act
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex);
         }
     }
 
@@ -61,7 +61,7 @@ public static void SaveBitmapData(byte[] imageData, string outputPath)
         }
         catch (Exception ex)
         {
-            Main._context.API.LogException(ClassName, $"Failed to save image: {outputPath}", ex);
+            Main.Context.API.LogException(ClassName, $"Failed to save image: {outputPath}", ex);
         }
     }
 

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs

@@ -19,7 +19,7 @@
 
     internal static string _faviconCacheDir;
 
-    internal static PluginInitContext _context;
+    internal static PluginInitContext Context { get; set; }
 
     internal static Settings _settings;
 
@@ -29,7 +29,7 @@
 
     public void Init(PluginInitContext context)
     {
-        _context = context;
+        Context = context;
 
         _settings = context.API.LoadSettingJsonStorage<Settings>();
 
@@ -42,7 +42,7 @@
 
     private static void LoadBookmarksIfEnabled()
     {
-        if (_context.CurrentPluginMetadata.Disabled)
+        if (Context.CurrentPluginMetadata.Disabled)
         {
             // Don't load or monitor files if disabled
             return;
@@ -84,7 +84,7 @@
                         Score = BookmarkLoader.MatchProgram(c, param).Score,
                         Action = _ =>
                         {
-                            _context.API.OpenUrl(c.Url);
+                            Context.API.OpenUrl(c.Url);
 
                             return true;
                         },
@@ -108,7 +108,7 @@
                         Score = 5,
                         Action = _ =>
                         {
-                            _context.API.OpenUrl(c.Url);
+                            Context.API.OpenUrl(c.Url);
                             return true;
                         },
                         ContextData = new BookmarkAttributes { Url = c.Url }
@@ -192,12 +192,12 @@
 
     public string GetTranslatedPluginTitle()
     {
-        return _context.API.GetTranslation("flowlauncher_plugin_browserbookmark_plugin_name");
+        return Localize.flowlauncher_plugin_browserbookmark_plugin_name();
     }
 
     public string GetTranslatedPluginDescription()
     {
-        return _context.API.GetTranslation("flowlauncher_plugin_browserbookmark_plugin_description");
+        return Localize.flowlauncher_plugin_browserbookmark_plugin_description();
     }
 
     public Control CreateSettingPanel()
@@ -211,22 +211,22 @@
         {
             new()
             {
-                Title = _context.API.GetTranslation("flowlauncher_plugin_browserbookmark_copyurl_title"),
-                SubTitle = _context.API.GetTranslation("flowlauncher_plugin_browserbookmark_copyurl_subtitle"),
+                Title = Localize.flowlauncher_plugin_browserbookmark_copyurl_title(),
+                SubTitle = Localize.flowlauncher_plugin_browserbookmark_copyurl_subtitle(),
                 Action = _ =>
                 {
                     try
                     {
-                        _context.API.CopyToClipboard(((BookmarkAttributes)selectedResult.ContextData).Url);
+                        Context.API.CopyToClipboard(((BookmarkAttributes)selectedResult.ContextData).Url);
 
                         return true;
                     }
                     catch (Exception e)
                     {
                         var message = "Failed to set url in clipboard";
-                        _context.API.LogException(ClassName, message, e);
+                        Context.API.LogException(ClassName, message, e);
 
-                        _context.API.ShowMsg(message);
+                        Context.API.ShowMsg(message);
 
                         return false;
                     }