Fix MCPAgent AttributeError due to outdated session references after MCPClients refactor
#1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all accesses to `self.mcp_clients.session` with checks on `self.mcp_clients.sessions` (plural). - Pick the first available session instead of assuming a single one. - Aligns MCPAgent behavior with recent MCPClients refactor to support multi-server connections.
- Update `think()` and `cleanup()` methods to correctly check `self.mcp_clients.sessions` instead of the old `self.mcp_clients.session`. - Prevent runtime AttributeError when the agent starts thinking or cleaning up. - Fully align MCPAgent with MCPClients multi-session support. - Allows agent to handle connections and disconnections properly after receiving user input. This completes the migration to the new MCPClients structure where multiple sessions are supported.
hfabio
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
self.mcp_clients.sessionsinstead of the obsoleteself.mcp_clients.session._refresh_tools,think(), andcleanup()methods to properly support multiple MCP sessions.run_mcp.py.Feature Docs
Influence
stdiomode or others.Result
stdio, prompts the user, and executes successfully without crashes.Other
7326cca4504fdaf5249ca3c2d36e39d09d83a6a7.