Add cleanup of 'Failed' jobs #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --ignore-not-found=true to delete. Cleans up some complaint when two scripts running beside each other and one deletes first (happens when testing changes to this script). Minor item. Also, clean up 'Failed' jobs else they just hang out.
johscheuer
reviewed
Jun 5, 2025
|
|
||
| # cleanup explicitly Failed jobs | ||
| # Filter by AGENT_NAME and job status condition "Failed"="True" | ||
| for job in $(kubectl get jobs -n "${namespace}" -o jsonpath='{range .items[?(@.status.conditions[*].type=="Failed" && @.status.conditions[*].status=="True")]}{.metadata.name}{"\\n"}{end}' 2>/dev/null | { grep -E "^${AGENT_NAME}-[0-9]+(-[0-9]+)?$" || true; }); do |
There was a problem hiding this comment.
This will get a bit tricky in bash, but I think we should delay the deletion of those failed jobs by 1 day to give some time for debugging (I'm not sure if we store the logs of the failed jobs somewhere).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --ignore-not-found=true to delete. Cleans up some complaint when
two scripts running beside each other and one deletes first (happens
when testing changes to this script). Minor item.
Also, clean up 'Failed' jobs else they just hang out.
Here are example Failed jobs.