use custom prefix when elevating privilages with check_priv() #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When check_priv() re-executes the script with sudo using the arguments given to build-xenon-toolchain, it looses any custom set $PREFIX given to it originally. I.e., if you do
PREFIX=/usr/local/custom build-xenon-toolchain toolchain, it will prompt for root privileges to be able to install into /usr/local/custom and then executesudo build-xenon-toolchain toolchainautomatically. This looses the given $PREFIX value and it will end up still installing to the default /usr/local/xenon because env vars are lost in in the sudo context. This specifies the $PREFIX variable during the sudo command as to not loose it and work as intended.Edit: Also removed a redundant deletion of the priv_check file since it is known to not exist.