Skip to content

Conversation

fiifff
Copy link

@fiifff fiifff commented Mar 28, 2025

This extension intercepts RSS entries during insertion, checks the URL against a user-configured list of allowed domains (JSON format), fetches the webpage content via curl, extracts the main content using XPath, and replaces the original entry's content.

  • Replaces RSS entry URLs with actual webpage content.
  • Allows users to define domain rules for content replacement.
  • Usually used to handle cases where the content retrieved via XPath from an article only includes a single title.

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@Alkarex
Copy link
Member

Alkarex commented Mar 28, 2025

Hello,
Try:

make fix-all
make test-all

@fiifff
Copy link
Author

fiifff commented Mar 28, 2025

Since this is my first attempt at writing code and submitting it to GitHub, the automated tests did not pass. I sincerely apologize for this. I will learn all the necessary processes, fix the errors, and resubmit after making the corrections.

@Alkarex
Copy link
Member

Alkarex commented Mar 28, 2025

No worries, do not close this PR but just keep pushing fixes to the same branch.
If you can, try to run locally:

make fix-all
make test-all

@fiifff
Copy link
Author

fiifff commented Mar 28, 2025

No worries, do not close this PR but just keep pushing fixes to the same branch. If you can, try to run locally:

make fix-all
make test-all

Thank you,I have learned to run tests locally.

make test-all

@Alkarex
Copy link
Member

Alkarex commented Mar 28, 2025

Very good. Try make fix-all as well

@fiifff
Copy link
Author

fiifff commented Mar 28, 2025

Very good. Try make fix-all as well

I ran make fix-all && make test-all, and no errors were returned. I also updated the README.md file.
Thank you for your guidance.

@fiifff
Copy link
Author

fiifff commented Mar 28, 2025

VSCode automatically added indentation, and I didn't notice it earlier.

@fiifff
Copy link
Author

fiifff commented Apr 29, 2025

Should I wait until the next version is released before submitting a new merge request?

@fiifff fiifff closed this Aug 29, 2025
@fiifff fiifff deleted the main branch August 29, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants