-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[ENHANCEMENT] [MODS] Data driven preferences #5816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PurSnake
wants to merge
17
commits into
FunkinCrew:develop
Choose a base branch
from
PurSnake:preference-rework-fuck
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Applying |
Added Number and Percentage preferences Reworked a bit preferences loading (A LOT) Reworked how user recievev pref value DefineUtil yo
and more silly nullSafety
Done, methinks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: haxe
PR modifies game code.
size: huge
A huge pull request with more than 500 changes.
status: needs revision
Cannot be approved because it is awaiting some work by the contributor.
topic: mods
Related to the creation or use of mods.
type: enhancement
Involves an enhancement or new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework of base preferences system (not including mobile specific, only base prefs)
data/preferences.json
Mods can add their own custom preferences via Polymod's
_merge
folderExample:
coolMod/_merge/data/preferences.json