feat: Geothermal Gradient for Single Phase flow #3193

npillardou · 2024-06-28T15:30:20Z

The purpose of this PR is to add the geothermal gradient capacities for single-phase flow.

At the moment the temperature VS Elevation is correlated with the composition VS Elevation, maybe this point could be extended to something that is independent of the composition:

<HydrostaticEquilibrium
  name="Initialisation"
  datumElevation="-3790"
  datumPressure="4.3e7"
  objectPath="ElementRegions"
  initialPhaseName="water"
  componentNames="{ co2, water }"
  componentFractionVsElevationTableNames="{ CO2VD, H2OVD }"
  temperatureVsElevationTableName="initTempTable" />

Further work is needed to account for composition in the hydrostatic pressure kernel, as it is done in CompositionalMultiphaseFlow.

codecov · 2024-06-28T16:14:33Z

Codecov Report

❌ Patch coverage is 17.47573% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.27%. Comparing base (e3d5c72) to head (9d84a71).

Files with missing lines	Patch %	Lines
...s/singlePhase/ThermalHydrostaticPressureKernel.hpp	0.00%	61 Missing ⚠️
...constitutive/fluid/singlefluid/SingleFluidBase.hpp	0.00%	13 Missing ⚠️
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp	60.71%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
- Coverage    58.31%   58.27%   -0.05%     
===========================================
  Files         1319     1320       +1     
  Lines       114626   114715      +89     
===========================================
+ Hits         66846    66852       +6     
- Misses       47780    47863      +83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…radient

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp

…radient

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp

paveltomin · 2025-08-08T18:36:08Z

@npillardou are you planning to finish this PR or it can be closed?

herve-gross · 2025-09-23T13:03:00Z

@dkachuma and @jhuang2601 please take a look

npillardou · 2025-09-23T14:15:41Z

@npillardou are you planning to finish this PR or it can be closed?

Sorry @paveltomin I totally forgot to answer you. I should take some time to investigate a good implementation, maybe with the help of Jian and Dick.

…radient

jafranc

Would it be possible to make it consistent with this:

GEOS/src/coreComponents/physicsSolvers/fluidFlow/kernels/compositional/HydrostaticPressureKernel.hpp

Lines 49 to 56 in 45f272c

    
           enum class ReturnType : integer 
        
           { 
        
             FAILED_TO_CONVERGE = 0, 
        
             DETECTED_MULTIPHASE_FLOW = 1, 
        
             SUCCESS = 2, 
        
             DETECTED_SINGLEPHASE_FLOW = 3, 
        
             PHASE_CORRECTION_NOT_NEEDED = 4 
        
           };

from #3795

jafranc

@npillardou can you add an inputFile using it ?

…radient

…tps://github.com/GEOS-DEV/GEOS into feature/npillardou/singlePhaseGeothermalGradient

paveltomin · 2025-10-07T23:21:28Z

src/coreComponents/constitutive/fluid/singlefluid/CompressibleSinglePhaseFluid.cpp

-    GEOS_THROW_IF_NE_MSG( value, ExponentApproximationType::Linear,
-                          GEOS_FMT( "{}: invalid model type in attribute '{}' (only linear currently supported)", getFullName(), attribute ),
-                          InputError );
+    GEOS_THROW_IF( value != ExponentApproximationType::Linear && value != ExponentApproximationType::Full,


linear is not supported anymore?

Both linear and full are valid. If the value is not one of these, it throws an error.

Removed default move assignment operator and its implementation from KernelWrapper.

Removed unnecessary blank line in KernelWrapper class.

…/singlePhaseGeothermalGradient

paveltomin · 2025-10-09T20:27:59Z

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp

-    forAll< parallelDevicePolicy< > >( targetSet.size(), [=] GEOS_HOST_DEVICE ( localIndex const i )
+    RAJA::ReduceMin< parallelHostReduce, real64 > minPressure( LvArray::NumericLimits< real64 >::max );
+
+    forAll< parallelHostPolicy >( targetSet.size(), [=] GEOS_HOST_DEVICE ( localIndex const i )


@rrsettgast @klevzoff
changing this from parallelDevicePolicy to parallelHostPolicy seems to resolve that unit test failure

…radient

Integrate SinglePhase Geothermal Gradient capacities

e0ff166

jhuang2601 assigned npillardou Jul 12, 2024

jhuang2601 self-requested a review July 12, 2024 17:15

rrsettgast requested review from CusiniM, paveltomin and ryar9534 as code owners December 3, 2024 20:15

Merge branch 'develop' into feature/npillardou/singlePhaseGeothermalG…

947daa8

…radient

paveltomin reviewed Dec 3, 2024

View reviewed changes

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp Show resolved Hide resolved

Merge branch 'develop' into feature/npillardou/singlePhaseGeothermalG…

bfba284

…radient

npillardou requested review from dkachuma and tjb-ltk as code owners February 11, 2025 16:44

tjb-ltk reviewed Feb 12, 2025

View reviewed changes

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp Show resolved Hide resolved

Merge branch 'develop' into feature/npillardou/singlePhaseGeothermalG…

2a08168

…radient

jhuang2601 requested review from OmarDuran, rasimHZ and rrsettgast as code owners September 23, 2025 21:03

jhuang2601 added 2 commits September 23, 2025 16:14

use full exp for densRelation in single phase flow

1f4ae42

use temperature in HydrostaticPressureKernel

e30462f

jhuang2601 changed the title ~~Geothermal Gradient for Single Phase flow~~ feat: Geothermal Gradient for Single Phase flow Sep 24, 2025

jhuang2601 added the type: feature New feature or request label Sep 24, 2025

herve-gross requested review from castelletto1, herve-gross and jafranc September 24, 2025 14:54

jafranc reviewed Sep 25, 2025

View reviewed changes

update SinglePhaseBase

751b27f

paveltomin and others added 5 commits October 7, 2025 09:08

Change KernelWrapper type to Full approximation

9493460

Merge branch 'develop' into feature/npillardou/singlePhaseGeothermalG…

f4a30eb

…radient

try this

d008909

Merge branch 'feature/npillardou/singlePhaseGeothermalGradient' of ht…

c575723

…tps://github.com/GEOS-DEV/GEOS into feature/npillardou/singlePhaseGeothermalGradient

try that

770d0d7

paveltomin requested a review from wrtobin as a code owner October 7, 2025 23:06

paveltomin reviewed Oct 7, 2025

View reviewed changes

paveltomin and others added 11 commits October 8, 2025 09:19

Remove default move assignment operator from KernelWrapper

71ddca7

Removed default move assignment operator and its implementation from KernelWrapper.

Remove blank line in KernelWrapper definition

45fe429

Removed unnecessary blank line in KernelWrapper class.

Remove blank line in KernelWrapper definition

b62c8f3

Removed unnecessary blank line in KernelWrapper class.

fix?

0431c58

correct check

52bf319

correct check

dcc09f0

try this

bb676a1

revert

afc2b16

debug output

467c466

Merge remote-tracking branch 'origin/develop' into feature/npillardou…

69851a9

…/singlePhaseGeothermalGradient

make host

8840d18

paveltomin reviewed Oct 9, 2025

View reviewed changes

jhuang2601 and others added 9 commits October 9, 2025 15:50

remove debug output

1fe52a2

update .integrated_tests.yaml

74b9d83

update BASELINE_NOTES.md

87aa22c

update .integrated_tests.yaml

c637cbb

Merge branch 'develop' into feature/npillardou/singlePhaseGeothermalG…

5e1369e

…radient

fix the timeout issue of PoroElastic_hybridHexPrism_co2_fim_3d

d4b5430

revert file path

8ee1c34

update .integrated_tests.yaml

b1ebdc0

update BASELINE_NOTES.md

412f94d

paveltomin merged commit 49c3a66 into develop Oct 10, 2025
25 of 26 checks passed

paveltomin deleted the feature/npillardou/singlePhaseGeothermalGradient branch October 10, 2025 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Geothermal Gradient for Single Phase flow #3193

feat: Geothermal Gradient for Single Phase flow #3193

Uh oh!

npillardou commented Jun 28, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jun 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

paveltomin commented Aug 8, 2025

Uh oh!

herve-gross commented Sep 23, 2025

Uh oh!

npillardou commented Sep 23, 2025

Uh oh!

jafranc left a comment

Uh oh!

jafranc left a comment

Uh oh!

paveltomin Oct 7, 2025

Uh oh!

jhuang2601 Oct 8, 2025

Uh oh!

paveltomin Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	enum class ReturnType : integer
	{
	FAILED_TO_CONVERGE = 0,
	DETECTED_MULTIPHASE_FLOW = 1,
	SUCCESS = 2,
	DETECTED_SINGLEPHASE_FLOW = 3,
	PHASE_CORRECTION_NOT_NEEDED = 4
	};

feat: Geothermal Gradient for Single Phase flow #3193

feat: Geothermal Gradient for Single Phase flow #3193

Uh oh!

Conversation

npillardou commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

paveltomin commented Aug 8, 2025

Uh oh!

herve-gross commented Sep 23, 2025

Uh oh!

npillardou commented Sep 23, 2025

Uh oh!

jafranc left a comment

Choose a reason for hiding this comment

Uh oh!

jafranc left a comment

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jhuang2601 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

npillardou commented Jun 28, 2024 •

edited

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading