Well Estimator + Constraint Selector #3735
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m for each well, 2) refactor accum/flux/presrelation calcs
…Newton for now, incl well dbg for now, compo1&2d run
… skip calcs if well not open, 3) parallel estimator works on a few cases tested
…initialization - part 1
…new&old logic, add basic basic constraint selection
…tor w/well estimator, 3) split constraint derivatives from well rate calculations, 4) add kernels for active constraint jacgen calcs , 5) needs testing
tjb-ltk
requested review from
rrsettgast,
CusiniM,
paveltomin,
castelletto1,
frankfeifan and
jhuang2601
as code owners
tjb-ltk
requested review from
Guotong-Ren,
dkachuma and
victorapm
as code owners
dkachuma
reviewed
Jul 28, 2025
| setDefaultValue( -1 ). | ||
| setSizedFromParent( 0 ). | ||
| setInputFlag( dataRepository::InputFlags::OPTIONAL ). | ||
| setDescription( "Global component densities of the injection stream [moles/m^3 or kg/m^3]" ); |
There was a problem hiding this comment.
I always assumed this to be fractions (mass or mole).
|
|
||
| Group * constraint = nullptr; | ||
| if( childKey == viewKeyStruct::minimumBHPConstraintString() ) | ||
| { |
There was a problem hiding this comment.
I'm guessing we are expecting only one constraint of each type. Is there a way we can enforce this? Something similar to the NonLinearParameters on the solvers.
There was a problem hiding this comment.
From the user, yes only one constraint of each type, but the code would still select the most limiting constraint. I will put code in to enforce this, and also valid combinations of constraints.
- There maybe more than one constraint of each type for operations like WHP or scaling, where the simulator imposes a constraint based on some allocation scheme, or for WHP, it would implement this as a BHP constraint, or other. Constraints are usually tagged with USER or SIM, where SIM being an internally generated constraint. How/when these SIM constraints get registered still needs to be addressed.
- you can assign inj and prod constraints to a well. This is more of an oil field usecase, cycling, but for geothermal this might be of use for closed loop well, which could have 2 boundary conditions.
| /// string key for the maximum volume rate for a injector | ||
| static constexpr char const * volumeInjectionConstraintString() { return "VolumeInjectionConstraint"; } | ||
| /// string key for the maximum mass rate for a producer | ||
| static constexpr char const * massProductionConstraintString() { return "massProductionConstraint"; } |
There was a problem hiding this comment.
Suggested change
| static constexpr char const * massProductionConstraintString() { return "massProductionConstraint"; } | |
| static constexpr char const * massProductionConstraintString() { return "MassProductionConstraint"; } |
| /// string key for the maximum mass rate for a producer | ||
| static constexpr char const * massProductionConstraintString() { return "massProductionConstraint"; } | ||
| /// string key for the maximum mass rate for a injector | ||
| static constexpr char const * massInjectionConstraintString() { return "massInjectionConstraint"; } |
There was a problem hiding this comment.
Suggested change
| static constexpr char const * massInjectionConstraintString() { return "massInjectionConstraint"; } | |
| static constexpr char const * massInjectionConstraintString() { return "MassInjectionConstraint"; } |
| * @brief This class describes a phase rate constraint used to control a injection well. | ||
| */ | ||
|
|
||
| class PhaseInjectionConstraint : public PhaseConstraint |
There was a problem hiding this comment.
How is PhaseInjectionConstraint different from VolumeInjectionConstraint?
There was a problem hiding this comment.
Probably should be called TotalVolume...
There was a problem hiding this comment.
and Phase could be called PhaseVolume
… base, 2) numerous fixes, 3) prod and inj well test cases w & wout estimator
…hp case using converted opm flowtable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add well estimator solve assuming fixed reservoir conditions
Refactor constraint specification
Introduced concept of well separator internally to remove ambiguity of fluid model quantities encountered when using same fluid model for constraint flashes and well element calculations. No input schema changes. This should be under separate PR to include formal well separator schema
Introduced limiting constraint selector to work with well estimator. At the beginning of the first n Newton Iterations , for each constraint, the well estimator applied and the most limiting constraint selected and set as the active constraint for the remaining Newton iterations.
PR currently has a fair bit of well debug code that will be removed