Skip to content

fix: Fix bug in stability test bypass #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dkachuma
Copy link
Contributor

Fixes a bug introduced in a previous PR. When the mixture is a pure component, we skip the stability test and mark it as single phase. However the incipient phase composition wasn't being assigned leading to a crash down the line. This PR fixes that.

@dkachuma dkachuma self-assigned this Aug 20, 2025
@dkachuma dkachuma added the type: bug Something isn't working label Aug 20, 2025
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Aug 20, 2025
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.45%. Comparing base (d323dcd) to head (760ae98).

Files with missing lines Patch % Lines
...ompositional/models/NegativeTwoPhaseFlashModel.hpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3783   +/-   ##
========================================
  Coverage    58.45%   58.45%           
========================================
  Files         1272     1272           
  Lines       109385   109387    +2     
========================================
+ Hits         63937    63939    +2     
  Misses       45448    45448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkachuma dkachuma added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants