-
Notifications
You must be signed in to change notification settings - Fork 97
feat: enable Kozeny-Carman Permeability for PorousSolid
#3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/coreComponents/constitutive/permeability/CarmanKozenyPermeability.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add the derivatives of permeability wrt volumetric strain somewhere in the code as well, given now the permeability can be a function of Biot porosity? Like in singlephasePoromechanics kernel?
A dedicated PR is required to add these derivatives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing derivatives should be addressed in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jhuang2601. Since we're not addressing the derivatives in this PR, I think it will be useful to add an example that uses the sequential solver without the need to calculate the derivatives.
@rrsettgast @castelletto1 @matteofrigo5 @Guotong-Ren This PR is ready for your review. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3790 +/- ##
===========================================
+ Coverage 58.15% 58.28% +0.12%
===========================================
Files 1318 1319 +1
Lines 114563 114700 +137
===========================================
+ Hits 66624 66851 +227
+ Misses 47939 47849 -90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These are expected failures and rebaseline is required
|
Instead of using constant permeability, this PR enables Kozeny-Carman Permeability (a porosity based approach) for
PorousSolid