Skip to content

Conversation

jhuang2601
Copy link
Contributor

Instead of using constant permeability, this PR enables Kozeny-Carman Permeability (a porosity based approach) for PorousSolid

Copy link
Contributor

@frankfeifan frankfeifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the derivatives of permeability wrt volumetric strain somewhere in the code as well, given now the permeability can be a function of Biot porosity? Like in singlephasePoromechanics kernel?

@jhuang2601
Copy link
Contributor Author

jhuang2601 commented Sep 18, 2025

Do we need to add the derivatives of permeability wrt volumetric strain somewhere in the code as well, given now the permeability can be a function of Biot porosity? Like in singlephasePoromechanics kernel?

A dedicated PR is required to add these derivatives.

Copy link
Collaborator

@paveltomin paveltomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing derivatives should be addressed in a future PR

Copy link
Contributor

@frankfeifan frankfeifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jhuang2601. Since we're not addressing the derivatives in this PR, I think it will be useful to add an example that uses the sequential solver without the need to calculate the derivatives.

@jhuang2601
Copy link
Contributor Author

@rrsettgast @castelletto1 @matteofrigo5 @Guotong-Ren This PR is ready for your review.

@jhuang2601 jhuang2601 added type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Sep 26, 2025
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.28%. Comparing base (2700326) to head (0614d87).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../coreComponents/constitutive/solid/PorousSolid.cpp 0.00% 4 Missing ⚠️
...titutive/permeability/CarmanKozenyPermeability.cpp 93.75% 1 Missing ⚠️
.../coreComponents/constitutive/solid/PorousSolid.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3790      +/-   ##
===========================================
+ Coverage    58.15%   58.28%   +0.12%     
===========================================
  Files         1318     1319       +1     
  Lines       114563   114700     +137     
===========================================
+ Hits         66624    66851     +227     
+ Misses       47939    47849      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhuang2601
Copy link
Contributor Author

These are expected failures and rebaseline is required

=======================
Test failures
=======================
PoroElastic_CarmanKozenyPermeability_fim_smoke_01
PoroElastic_CarmanKozenyPermeability_fim_smoke_04
PoroElastic_CarmanKozenyPermeability_sequential_smoke_01
PoroElastic_CarmanKozenyPermeability_sequential_smoke_04
staircase_3d_01
staircase_3d_08
staircase_3d_27

@jhuang2601 jhuang2601 added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Sep 26, 2025
@paveltomin paveltomin merged commit cba065b into develop Sep 29, 2025
28 checks passed
@paveltomin paveltomin deleted the feature/jhuang/permeability_PorousSolid branch September 29, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants