Skip to content

docs: fix spelling issues #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: fix spelling issues #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cbb9c4
Update README.md
nnsW3 Sep 27, 2024
3fe51bf
Update TestBytesLib2.sol
nnsW3 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ _**2021-01-07**_

A bug regarding zero-length slices was disclosed by @MrChico following an audit to the Optimism codebase.

The exact bug happened under the following conditions: if memory slots higher then the current free-memory pointer were tainted before calling the `slice` method with a desired length of `0`, the returned bytes array, instead of being a zero-length slice was an array of arbitrary length based on the values that previously populated that memory region.
The exact bug happened under the following conditions: if memory slots higher than the current free-memory pointer were tainted before calling the `slice` method with a desired length of `0`, the returned bytes array, instead of being a zero-length slice was an array of arbitrary length based on the values that previously populated that memory region.

Overall, the usage of zero-length slices should be pretty unusual and, as such, hopefully, this bug does not have far-reaching implications. Nonetheless, *please update the library to the new version if you're using it in production*.

Expand Down
2 changes: 1 addition & 1 deletion test/TestBytesLib2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ AssertBytes.equal(checkBytesZeroLength, checkBytesZeroLengthRight, "Sanity check
assertEq(resultBytes, testBytes);
AssertBytes.equal(resultBytes, testBytes, "Multiple (*2) of 32 bytes slice failed.");

// With v0.5.x we can now entirely replace the ThrowProxy patterns that was creating issues with the js-vm
// With v0.5.x we can now entirely replace the ThrowProxy patterns that were creating issues with the js-vm
// and use an external call to our own contract with the function selector, since Solidity now gives us
// access to those
bool r;
Expand Down