Add some tweaks to rmv frontend #23
Conversation
- Update the BUILD.md file to fix inconsistencies in the Windows pre-build options. - Add an option in Settings to toggle between KB and KiB units for size display. - Add "Dimension", "MipLevel" and "Format" columns in the Resource list for Textures, DepthStencils and RenderTargets. - Add a button to export all resource details from the Resource list.
- Add a slider in the Resource list to filter resources by mip level.
There was a problem hiding this comment.
This is great, thank you!
We have a release planned soon, so I will push these changes after the next release goes live. I will then merge this PR into our main code branch so the next binary release will contain these changes.
I noticed you implemented the 'dump resources'. This is part of our internal build but at the time, we felt that external users may not have found this feature particularly useful. Rather than have the button to "dump resources", I may add a right-click context menu to the resource table to allow the dump to be exported to the clipboard as a text file or a .csv file, in the same way as the resource details table. Do you have any objections to this?
|
Thank you for your review! I have no objections, and you are free to modify my code as you see fit. Furthermore, I noticed that I only added the Mip Level filter to Resource List and missed adding it to Memory Leak Finder. I’ve submitted an additional commit to address this. This commit also fixes a bug where adjusting the combo box in the Memory Leak Finder wouldn’t update the summary label at the bottom.
Thanks again! |
Some tweaks to rmv frontend: