[partner-portal-58] Enable rubocop #553
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-m-m
commented
Jun 9, 2025
| @@ -44,10 +44,13 @@ exclude: | |||
| - .sass-cache/ | |||
| - .jekyll-cache/ | |||
| - assets/scss | |||
| - bin | |||
There was a problem hiding this comment.
This isn't currently used in this repo, but bundle binstubs might still be created locally depending on your dev env and should be ignored
h-m-m
commented
Jun 9, 2025
| @@ -2,22 +2,26 @@ source 'https://rubygems.org' | |||
|
|
|||
| ruby File.read('.ruby-version').strip | |||
|
|
|||
| gem 'csv' | |||
There was a problem hiding this comment.
The bump in Ruby version changes where Ruby's CSV lives
h-m-m
force-pushed
the
hmm/partner-portal-58/enable-rubocop
branch
from
f038b39 to
7ef75d0
Compare
|
I think this can be done under ticket Portal#144, for the purposes of tracking work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Tickets or Conversations
#552
[identity-dev-docs] direct links to accordions should auto-expand — on GitLab
(Previously https://cm-jira.usa.gov/browse/LG-14871 )
Description of Changes
While working on #552 I found it useful to enable Rubocop.
Bumping Ruby to 3.4.x also helps make one Rubocop rule not strictly needed, see https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.4.0.md
The changes in this PR are
and, unrelated to the above items