Skip to content

Rework websockets #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rework websockets #14

wants to merge 1 commit into from

Conversation

Cryma
Copy link
Member

@Cryma Cryma commented Oct 10, 2021

  • Add monotonically increasing ids to websocket messages
  • Save websocket messages
  • Split websocket server from REST backend
  • Add continue-ability to continue abandoned sessions and replay messages

@codecov-commenter
Copy link

Codecov Report

Merging #14 (1a46047) into main (6e9a7bb) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   94.72%   95.09%   +0.36%     
==========================================
  Files          32       32              
  Lines         759      755       -4     
==========================================
- Hits          719      718       -1     
+ Misses         40       37       -3     
Impacted Files Coverage Δ
ferrum-websocket/src/lib.rs 89.55% <100.00%> (+2.40%) ⬆️
ferrum-websocket/src/messages.rs 100.00% <100.00%> (ø)
ferrum-websocket/src/server.rs 81.91% <100.00%> (+0.86%) ⬆️
src/routes/channels/create_message.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9a7bb...1a46047. Read the comment docs.

@Cryma Cryma force-pushed the main branch 3 times, most recently from de67767 to cdcad6b Compare October 29, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants