-
Notifications
You must be signed in to change notification settings - Fork 110
Fix composer not being locked after the channel was frozen #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
testableapple
wants to merge
7
commits into
develop
Choose a base branch
from
fix/messages-in-frozen-channel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public Interface open class MessageComposerViewModel: ObservableObject
- public var sendButtonEnabled: Bool
+ public var isSendMessageEnabled: Bool
- public var sendInChannelShown: Bool
+ public var sendButtonEnabled: Bool
- public var isDirectChannel: Bool
+ public var sendInChannelShown: Bool
- public var showCommandsOverlay: Bool
+ public var isDirectChannel: Bool
- public var inputComposerShouldScroll: Bool
+ public var showCommandsOverlay: Bool
-
+ public var inputComposerShouldScroll: Bool
-
+
- public init(channelController: ChatChannelController,messageController: ChatMessageController?,eventsController: EventsController? = nil,quotedMessage: Binding<ChatMessage?>? = nil)
+
-
+ public init(channelController: ChatChannelController,messageController: ChatMessageController?,eventsController: EventsController? = nil,quotedMessage: Binding<ChatMessage?>? = nil)
-
+
- public func fillEditedMessage(_ editedMessage: ChatMessage?)
+
- public func fillDraftMessage()
+ public func fillEditedMessage(_ editedMessage: ChatMessage?)
- public func updateDraftMessage(quotedMessage: ChatMessage?,isSilent: Bool = false,extraData: [String: RawJSON] = [:])
+ public func fillDraftMessage()
- public func deleteDraftMessage()
+ public func updateDraftMessage(quotedMessage: ChatMessage?,isSilent: Bool = false,extraData: [String: RawJSON] = [:])
- open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping () -> Void)
+ public func deleteDraftMessage()
- public func change(pickerState: AttachmentPickerState)
+ open func sendMessage(quotedMessage: ChatMessage?,editedMessage: ChatMessage?,isSilent: Bool = false,skipPush: Bool = false,skipEnrichUrl: Bool = false,extraData: [String: RawJSON] = [:],completion: @escaping () -> Void)
- public func imageTapped(_ addedAsset: AddedAsset)
+ public func change(pickerState: AttachmentPickerState)
- public func imagePasted(_ image: UIImage)
+ public func imageTapped(_ addedAsset: AddedAsset)
- public func removeAttachment(with id: String)
+ public func imagePasted(_ image: UIImage)
- public func cameraImageAdded(_ image: AddedAsset)
+ public func removeAttachment(with id: String)
- public func isImageSelected(with id: String)-> Bool
+ public func cameraImageAdded(_ image: AddedAsset)
- public func customAttachmentTapped(_ attachment: CustomAttachment)
+ public func isImageSelected(with id: String)-> Bool
- public func isCustomAttachmentSelected(_ attachment: CustomAttachment)-> Bool
+ public func customAttachmentTapped(_ attachment: CustomAttachment)
- public func askForPhotosPermission()
+ public func isCustomAttachmentSelected(_ attachment: CustomAttachment)-> Bool
- public func handleCommand(for text: Binding<String>,selectedRangeLocation: Binding<Int>,command: Binding<ComposerCommand?>,extraData: [String: Any])
+ public func askForPhotosPermission()
- open func convertAddedAssetsToPayloads()throws -> [AnyAttachmentPayload]
+ public func handleCommand(for text: Binding<String>,selectedRangeLocation: Binding<Int>,command: Binding<ComposerCommand?>,extraData: [String: Any])
- public func checkForMentionedUsers(commandId: String?,extraData: [String: Any])
+ open func convertAddedAssetsToPayloads()throws -> [AnyAttachmentPayload]
- public func clearRemovedMentions()
+ public func checkForMentionedUsers(commandId: String?,extraData: [String: Any])
- public func clearInputData()
+ public func clearRemovedMentions()
- public func checkChannelCooldown()
+ public func clearInputData()
+ public func checkChannelCooldown() |
SDK Size
|
|
StreamChatSwiftUI XCSize
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolve https://linear.app/stream/issue/IOS-1191
🎯 Goal
Fix composer not being locked after the channel was frozen
🎨 Showcase
🧪 Manual Testing Notes
Frozen
☑️ Contributor Checklist
docs-content
repo