feat: adaptive floating video dimensions #1969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Currently our floating video dimensions are hardcoded. This looks fine in a iPhone Xs phone. Anything taller or wider, it looks small.
Our dogfood app had a custom implementation based on window dimensions so we didnt use it. But this is also flawed, as this didnt adapt to portrait to landscape change.
📝 Implementation notes
I implemented the Android AOSP PiP mode algorithm. Which is based on the video dimensions.
Now it works well on larger devices like iPad too. Looks similar to Facetime behaviour now. If the video changes to landscape, will adapt to that as well now.