fix(recording): more reliable detection of the dominant speaker #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry tracking to monitor when the dominant speaker changes in the spotlight layout. When a new participant becomes the dominant speaker, the change is logged via the call tracer for monitoring and debugging purposes.
Key Changes:
- Implements speaker change detection using
useRefto track the previous speaker - Adds
useEffecthook to trace spotlight speaker transitions viaactiveCall.tracer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sample-apps/react/egress-composite/src/components/layouts/DominantSpeaker/DominantSpeaker.tsx
Outdated
Show resolved
Hide resolved
sample-apps/react/egress-composite/src/components/layouts/DominantSpeaker/DominantSpeaker.tsx
Outdated
Show resolved
Hide resolved
jdimovska
approved these changes
Oct 30, 2025
oliverlaz
changed the title
oliverlaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Extends the egress-composite app with additional tracing logs for dominant speaker changes.
Also, fixes a "participant sorting" bug that, in some circumstances, caused an incorrect participant to be flagged as the dominant one.
Ref: https://getstream.slack.com/archives/C05KL0HEWLA/p1761659680348299
Ticket: https://linear.app/stream/issue/REACT-630/recording-unexpected-participant-is-flagged-as-dominant-one