Breaking: Uses Swift Concurrency #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
fcd2112 to
0b70753
Compare
paulofaria
previously approved these changes
Jun 24, 2025
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
0b70753 to
f010d6f
Compare
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
4 times, most recently
from
a561b89 to
48b6891
Compare
NeedleInAJayStack
changed the title
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
3 times, most recently
from
7292d74 to
ef0ffea
Compare
This removes the NIO dependency. It is breaking because it removes all Swift NIO-isms that were present in the public APIs (like EventLoopFuture and EventLoopGroup argument/return types).
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
ef0ffea to
55eaeaa
Compare
NeedleInAJayStack
changed the title
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
55eaeaa to
492dfb1
Compare
|
@paulofaria This should be ready for review now! |
JaapWijnen
requested review from
JaapWijnen
and removed request for
JaapWijnen
paulofaria
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the NIO dependency. It is breaking because it removes all Swift NIO-isms that were present in the public APIs (like EventLoopFuture and EventLoopGroup argument/return types).
Do not merge until GraphQLSwift/GraphQL#166 has been merged and tagged