Skip to content

Pluggable prefix mapper for entity permissions checks #22776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2025

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Jun 3, 2025

Description

This PR modularises the prefix mapping for the permissions checks on entities.
It now supports adding mappings per plugin (enterprise plugins) and can check for special ids as we use with immutable entities.

This PR also fixes the links for the Security App for Last Opened & Favourites.
fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/10894

/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/10968

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise requested a review from dennisoelkers June 3, 2025 11:39
@janheise janheise changed the title Draft: Pluggable Entity permission checker Pluggable prefix mapper for entity permissions checks Jun 5, 2025
@janheise janheise force-pushed the fix/security_prmissions2 branch from ea6da4d to 5ab223a Compare June 5, 2025 12:38
@janheise janheise marked this pull request as ready for review June 5, 2025 12:38
@janheise janheise force-pushed the fix/security_prmissions2 branch from e2d72d0 to f62b455 Compare June 6, 2025 07:54
@janheise janheise merged commit 1159e96 into master Jun 6, 2025
7 checks passed
@janheise janheise deleted the fix/security_prmissions2 branch June 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants