Remove private headers from list of headers installed #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol and
vchoi-hdfgroup
as code owners
byrnHDF
added
the
Priority - 2. Medium
byrnHDF
requested review from
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
src/H5FDsubfiling/CMakeLists.txt
Outdated
| @@ -2,7 +2,7 @@ cmake_minimum_required (VERSION 3.18) | |||
| project (HDF5_H5FD_SUBFILING C) | |||
|
|
|||
| # Sanity checking | |||
| if (NOT H5FD_HDRS) | |||
| if (NOT H5FD_PUBLIC_HDRS) | |||
| message (FATAL_ERROR "internal configure error - H5FD_HDRS not set") | |||
There was a problem hiding this comment.
Minor - H5FD_HDRS -> H5FD_PUBLIC_HDRS
| ${HDF5_SRC_DIR}/H5FDonion_index.h | ||
| ${HDF5_SRC_DIR}/H5FDonion_priv.h | ||
| ${HDF5_SRC_DIR}/H5FDpkg.h | ||
| ${HDF5_SRC_DIR}/H5FDprivate.h |
There was a problem hiding this comment.
May need another review of all the headers, as this list should probably also include H5FDmulti_private.h, H5FDros3_s3comms.h, H5FDstdio_private.h and more. This is one of the reasons I think at least each file driver should be put in its own sub-directory to make this a bit more clear.
src/CMakeLists.txt
Outdated
| ${HDF5_SRC_DIR}/H5FDpkg.h | ||
| ${HDF5_SRC_DIR}/H5FDprivate.h | ||
| ${HDF5_SRC_DIR}/H5FDros3_s3comms.h | ||
| ${HDF5_SRC_DIR}/H5FDstdio_int.h |
There was a problem hiding this comment.
This header file doesn't exist; just needs to be removed
jhendersonHDF
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5501