Samira w2 using ap is #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddoyediran
reviewed
Feb 11, 2025
| // TODO return a promise using `fetch()` | ||
| async function requestData(url) { | ||
| try { | ||
| const response = await fetch(url); |
There was a problem hiding this comment.
Nice job with the fetch implementation.
ddoyediran
reviewed
Feb 11, 2025
| async function fetchData(url) { | ||
| try { | ||
| const response = await fetch(url); | ||
| if (!response.ok) { |
There was a problem hiding this comment.
Well done, checking the "HTTP errors" here.
ddoyediran
reviewed
Feb 11, 2025
| }); | ||
| export async function rollDieUntil(desiredValue) { | ||
| let value; | ||
| do { |
There was a problem hiding this comment.
Great thinking here. To make things more simpler (easy to read and less code), we can use while loop without do as follows:
...
while (value !== desiredValue) {
value = await rollDie();
}
...
ddoyediran
reviewed
Feb 11, 2025
| @@ -15,20 +15,28 @@ import { rollDie } from '../../helpers/pokerDiceRoller.js'; | |||
|
|
|||
| export function rollDice() { | |||
| const dice = [1, 2, 3, 4, 5]; | |||
| // TODO complete this function; use Promise.race() and rollDie() | |||
| rollDie(1); // TODO placeholder: modify as appropriate | |||
| return Promise.race(dice.map((die) => rollDice(die))); | |||
There was a problem hiding this comment.
- We are suppose to pass each
dieto therollDie(die)method notrollDice(die)))on line 18. The current solution will turn to a recursion (that a function calling itself), which leads to the error messageMaximum call stack sizein another word Stack overflow because we don't have a way (base case) to breakout of the recursive call. The final code on line 18 should look like thisreturn Promise.race(dice.map((die) => rollDie(die)));.
ddoyediran
reviewed
Feb 11, 2025
ddoyediran
reviewed
Feb 11, 2025
| @@ -7,20 +7,21 @@ async function getData(url) { | |||
| const response = await fetch(url); | |||
There was a problem hiding this comment.
For exercise 5, I got this error message Something went wrong: fetch is not defined when I run node ex5-vscDebug.js in the terminal. I got the same error when I reviewed Konjit code.
Note: The issue is that we are using fetch() method but we didn't import It or have access to it.
She told me the code works on her end, probably the problem is from my end.
ddoyediran
reviewed
Feb 11, 2025
| @@ -16,29 +16,41 @@ Full description at: https://github.com/HackYourFuture/Assignments/blob/main/3-U | |||
| url with `.shx`. There is no server at the modified url, therefore this | |||
There was a problem hiding this comment.
@samira313 Great job with the solutions. We are almost there. Let's try to make exercise 4 work. Once our exercise 4 is working, I will approve the homework. Let me know if you have any questions.
|
Hi Damilare David Oyediran,
Thank you for your detailed feedback! I have now fixed the issue in
exercise 4 by correctly passing die to rollDie(die) instead of
rollDice(die). The recursion issue is resolved, and the code works as
expected.
Also, regarding exercise 5, I am not encountering any errors. I have
attached a screenshot for verification. Please let me know if you need any
further modifications.
Thanks again for your guidance!
Best,
Samira Ahmadi
…On Tue, 11 Feb 2025 at 23:37, Damilare David Oyediran < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In 3-UsingAPIs/Week2/assignment/ex1-programmerFun/index.js
<#62 (comment)>
:
> @@ -16,29 +16,41 @@ Full description at: https://github.com/HackYourFuture/Assignments/blob/main/3-U
url with `.shx`. There is no server at the modified url, therefore this
@samira313 <https://github.com/samira313> Great job with the solutions.
We are almost there. Let's try to make exercise 4 work. Once our exercise 4
is working, I will approve the homework. Let me know if you have any
questions.
—
Reply to this email directly, view it on GitHub
<#62 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKWT54MNSGYWWTFPKLB6EUL2PJ3RXAVCNFSM6AAAAABWMWDYDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJQGI2DAMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
ddoyediran
approved these changes
Feb 12, 2025
|
Thank you for the update. Congratulations on completing Week 2 Homework. Great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.