forked from HackYourFuture/Assignments
-
Notifications
You must be signed in to change notification settings - Fork 10
Oleksandr Starshynov week3 JavaScript #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aleksandrstarshynov
wants to merge
3
commits into
HackYourAssignment:main
Choose a base branch
from
aleksandrstarshynov:oleksandr_starshynov-w3-JavaScript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
## Test Summary | ||
|
||
**Mentors**: For more information on how to review homework assignments, please refer to the [Review Guide](https://github.com/HackYourFuture/mentors/blob/main/assignment-support/review-guide.md). | ||
|
||
### 1-JavaScript - Week3 | ||
|
||
| Exercise | Passed | Failed | ESLint | | ||
|----------------------------|--------|--------|--------| | ||
| ex1-doubleEvenNumbers.test | 1 | - | ✓ | | ||
| ex2-mondaysWorth.test | 2 | - | ✓ | | ||
| ex3-lemonAllergy.test | 3 | - | ✓ | | ||
| ex4-observable | 3 | - | ✓ | | ||
| ex5-wallet | 5 | - | ✓ | |
22 changes: 3 additions & 19 deletions
22
1-JavaScript/Week3/assignment/ex1-doubleEvenNumbers.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
1-JavaScript/Week3/test-reports/ex1-doubleEvenNumbers.test.report.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS 1-JavaScript/Week3/assignment/ex1-doubleEvenNumbers.test.js | ||
js-wk3-ex1-doubleEvenNumbers | ||
✅ doubleEvenNumbers should take the even numbers and double them (3 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 1 passed, 1 total | ||
Snapshots: 0 total | ||
Time: 0.945 s, estimated 1 s | ||
Ran all test suites matching /D:\\HYF\\HYF-Assignments-cohort52\\1-JavaScript\\Week3\\assignment\\ex1-doubleEvenNumbers.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
19 changes: 19 additions & 0 deletions
19
1-JavaScript/Week3/test-reports/ex2-mondaysWorth.test.report.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
*** Unit Test Error Report *** | ||
|
||
console.log | ||
€187.50 | ||
|
||
at Object.log (1-JavaScript/Week3/assignment/ex2-mondaysWorth.test.js:40:9) | ||
|
||
PASS 1-JavaScript/Week3/assignment/ex2-mondaysWorth.test.js | ||
js-wk3-mondaysWorth | ||
✅ computeEarnings should take two parameters (3 ms) | ||
✅ computeEarnings should compute the earnings as a formatted Euro amount (1 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 2 passed, 2 total | ||
Snapshots: 0 total | ||
Time: 0.768 s, estimated 1 s | ||
Ran all test suites matching /D:\\HYF\\HYF-Assignments-cohort52\\1-JavaScript\\Week3\\assignment\\ex2-mondaysWorth.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
15 changes: 15 additions & 0 deletions
15
1-JavaScript/Week3/test-reports/ex3-lemonAllergy.test.report.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS 1-JavaScript/Week3/assignment/ex3-lemonAllergy.test.js | ||
js-wk3-ex3-lemonAllergy | ||
✅ sanitizeFruitBasket should take two parameters (3 ms) | ||
✅ sanitizeFruitBasket should not modify the original `fruitBasket` array | ||
✅ sanitizeFruitBasket should return a new array that does not include the unwanted `lemon` (1 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 3 passed, 3 total | ||
Snapshots: 0 total | ||
Time: 1.307 s | ||
Ran all test suites matching /D:\\HYF\\HYF-Assignments-cohort52\\1-JavaScript\\Week3\\assignment\\ex3-lemonAllergy.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS 1-JavaScript/Week3/assignment/ex4-observable/ex4-observable.test.js | ||
js-wk3-ex4-observable | ||
✅ createObservable should exist and be a function (7 ms) | ||
✅ createObservable should return an object with `subscribe` and a `notify` function properties (1 ms) | ||
✅ observable should notify all subscribers of any notification (2 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 3 passed, 3 total | ||
Snapshots: 0 total | ||
Time: 0.866 s, estimated 1 s | ||
Ran all test suites matching /D:\\HYF\\HYF-Assignments-cohort52\\1-JavaScript\\Week3\\assignment\\ex4-observable\\ex4-observable.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/1-JavaScript/Week3/unit-tests/ex5-wallet.test.js | ||
js-wk3-ex5-wallet | ||
✅ q1: At line 24, which variables are in the scope marked Closure? (2 ms) | ||
✅ q2: What is in the Call Stack, from top to bottom? (1 ms) | ||
✅ q3: What tooltip appears when hovering over the third debug button? | ||
✅ q4: What is displayed in the console? (1 ms) | ||
✅ q5: The owner of the wallet with insufficient funds is? | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 5 passed, 5 total | ||
Snapshots: 0 total | ||
Time: 0.717 s, estimated 1 s | ||
Ran all test suites matching /D:\\HYF\\HYF-Assignments-cohort52\\.dist\\1-JavaScript\\Week3\\unit-tests\\ex5-wallet.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done completing Week 3 assignment. Approved!!!