forked from HackYourFuture/Assignments
-
Notifications
You must be signed in to change notification settings - Fork 10
ILIA_BUBNOV-w1-Browsers #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MBreathe
wants to merge
5
commits into
HackYourAssignment:main
Choose a base branch
from
MBreathe:ILIA_BUBNOV-w1-Browsers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
079dc76
finished browsers assignment for the first week
MBreathe f0c79a7
fixed issues based on the given comments
MBreathe 820cc55
fixed major bug
MBreathe a093cfc
fixed small errors according to given feedback
MBreathe 9597092
fixed a lot of small things
MBreathe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
## Test Summary | ||
|
||
**Mentors**: For more information on how to review homework assignments, please refer to the [Review Guide](https://github.com/HackYourFuture/mentors/blob/main/assignment-support/review-guide.md). | ||
|
||
### 2-Browsers - Week1 | ||
|
||
| Exercise | Passed | Failed | ESLint | | ||
|------------------|--------|--------|--------| | ||
| ex1-bookList | 6 | - | ✓ | | ||
| ex2-aboutMe | 4 | - | ✓ | | ||
| ex3-hijackLogo | 3 | - | ✓ | | ||
| ex4-whatsTheTime | 6 | - | ✓ | | ||
| ex5-catWalk | 5 | - | ✓ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,38 @@ | ||
/* Write your style here */ | ||
html { | ||
font-size: 62.5% !important; | ||
background-color: #faf6f6; | ||
} | ||
* { | ||
box-sizing: border-box; | ||
margin: 0; | ||
padding: 0; | ||
} | ||
#bookList { | ||
display: flex; | ||
flex-wrap: wrap; | ||
} | ||
ul { | ||
list-style-type: none; | ||
} | ||
li { | ||
display: inline-block; | ||
background-color: green; | ||
padding: 1rem; | ||
margin: 1rem; | ||
border-radius: 1rem; | ||
width: 40rem; | ||
} | ||
h1 { | ||
font-size: 4rem; | ||
text-align: center; | ||
margin: 1rem; | ||
} | ||
p { | ||
font-size: 1.5rem; | ||
margin-bottom: 1rem; | ||
text-align: center; | ||
} | ||
.not-read { | ||
background-color: red; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
/* 3. Add a css rule for .list-item to make the color red. */ | ||
.list-item { | ||
color: red; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/2-Browsers/Week1/unit-tests/ex1-bookList.test.js | ||
br-wk1-ex1-bookList | ||
✅ HTML should be syntactically valid (107 ms) | ||
✅ should have all TODO comments removed | ||
✅ should contain a <ul> that is a child of <div id="bookList"> (2 ms) | ||
✅ should contain a <ul> with 3 <li> elements (1 ms) | ||
✅ should contain an <li> with title and author for each book of the `myBooks` array (2 ms) | ||
✅ should contain an <img> element for each book | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 6 passed, 6 total | ||
Snapshots: 0 total | ||
Time: 3.963 s, estimated 4 s | ||
Ran all test suites matching /C:\\Users\\BidonLoverXXX\\WebstormProjects\\Assignments-cohort52\\.dist\\2-Browsers\\Week1\\unit-tests\\ex1-bookList.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/2-Browsers/Week1/unit-tests/ex2-aboutMe.test.js | ||
br-wk1-ex2-aboutMe | ||
✅ should be syntactically valid (107 ms) | ||
✅ should have all TODO comments removed (1 ms) | ||
✅ each <li> should have the CSS class `list-item` | ||
✅ each <li> should rendered red (= rgb(255, 0, 0)) (17 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 4 passed, 4 total | ||
Snapshots: 0 total | ||
Time: 3.228 s | ||
Ran all test suites matching /C:\\Users\\BidonLoverXXX\\WebstormProjects\\Assignments-cohort52\\.dist\\2-Browsers\\Week1\\unit-tests\\ex2-aboutMe.test.js/i. | ||
No linting errors detected. | ||
|
||
|
||
*** Spell Checker Report *** | ||
|
||
2-Browsers/Week1/assignment/ex2-aboutMe/index.js:16:28 - Unknown word (mbreathe) | ||
2-Browsers/Week1/assignment/ex2-aboutMe/index.js:18:28 - Unknown word (bratsk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/2-Browsers/Week1/unit-tests/ex3-hijackLogo.test.js | ||
br-wk1-ex3-hijackLogo | ||
✅ should have all TODO comments removed (1 ms) | ||
✅ should set the `.src` property | ||
✅ should set the `.srcset` property (1 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 3 passed, 3 total | ||
Snapshots: 0 total | ||
Time: 0.572 s, estimated 1 s | ||
Ran all test suites matching /C:\\Users\\BidonLoverXXX\\WebstormProjects\\Assignments-cohort52\\.dist\\2-Browsers\\Week1\\unit-tests\\ex3-hijackLogo.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/2-Browsers/Week1/unit-tests/ex4-whatsTheTime.test.js | ||
br-wk1-ex4-whatsTheTime | ||
✅ HTML should be syntactically valid (105 ms) | ||
✅ should have all TODO comments removed (1 ms) | ||
✅ should use `setInterval()` | ||
✅ should not call `setInterval()` more than once (2013 ms) | ||
✅ should use `window.onload` or `window.addEventListener()` for the `load` or `DOMContentLoaded` event | ||
✅ `window.onload` or `window.addEventListener` should not call its event handler function (1 ms) | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 6 passed, 6 total | ||
Snapshots: 0 total | ||
Time: 5.235 s | ||
Ran all test suites matching /C:\\Users\\BidonLoverXXX\\WebstormProjects\\Assignments-cohort52\\.dist\\2-Browsers\\Week1\\unit-tests\\ex4-whatsTheTime.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
*** Unit Test Error Report *** | ||
|
||
PASS .dist/2-Browsers/Week1/unit-tests/ex5-catWalk.test.js | ||
br-wk1-ex5-catWalk | ||
✅ HTML should be syntactically valid (110 ms) | ||
✅ should have all TODO comments removed (1 ms) | ||
✅ should use `setInterval()` and/or `setTimeout()` | ||
✅ should use `window.onload` or `window.addEventListener()` for the `load` or `DOMContentLoaded` event (1 ms) | ||
✅ `window.onload` or `window.addEventListener` should not call its event handler function | ||
|
||
Test Suites: 1 passed, 1 total | ||
Tests: 5 passed, 5 total | ||
Snapshots: 0 total | ||
Time: 3.397 s, estimated 4 s | ||
Ran all test suites matching /C:\\Users\\BidonLoverXXX\\WebstormProjects\\Assignments-cohort52\\.dist\\2-Browsers\\Week1\\unit-tests\\ex5-catWalk.test.js/i. | ||
No linting errors detected. | ||
No spelling errors detected. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.