Oleksandr Starshynov w2 UsingAPIs #40
Conversation
| const dice = [1, 2, 3, 4, 5]; | ||
| // TODO complete this function; use Promise.race() and rollDie() | ||
| rollDie(1); // TODO placeholder: modify as appropriate | ||
| const promises = dice.map(() => rollDie()); |
There was a problem hiding this comment.
Though the output of this code is close to what we want but something is missing:
The dice array is [1, 2, 3, 4, 5], but the values in this array are not used in the map() function.
The map() function calls rollDie() five times (once for each element in the array), but it does not pass any arguments to rollDie().
Therefore, line 10 was supposed to be like const promises = dice.map((dice) => rollDie(dice));.
Can you update this, so that our output in the terminal looks as follows:
09:10:37.116 Die 1 scheduled for 4 rolls...
09:10:37.128 Die 1 is now: NINE
09:10:37.129 Die 2 scheduled for 4 rolls...
09:10:37.129 Die 2 is now: TEN
09:10:37.129 Die 3 scheduled for 6 rolls...
09:10:37.129 Die 3 is now: NINE
09:10:37.130 Die 4 scheduled for 6 rolls...
09:10:37.130 Die 4 is now: NINE
...
| @@ -11,21 +11,20 @@ async function getData(url) { | |||
| function renderLaureate({ knownName, birth, death }) { | |||
| @@ -11,21 +11,20 @@ async function getData(url) { | |||
| function renderLaureate({ knownName, birth, death }) { | |||
| console.log(`\nName: ${knownName.en}`); | |||
| console.log(`Birth: ${birth.date}, ${birth.place.locationString}`); | |||
There was a problem hiding this comment.
We are supposed to log the en property of this object birth.place.locationString.en. So that line 13 looks like:
console.log(`Birth: ${birth.date}, ${birth.place.locationString.en}`);
| function renderLaureates(laureates) { | ||
| laureates.forEach(renderLaureate); | ||
| if (death) { | ||
| console.log(`Death: ${death.date}, ${death.place.locationString}`); |
There was a problem hiding this comment.
Same as line 13:
console.log(`Birth: ${birth.date}, ${birth.place.locationString.en}`);
| laureates.forEach(renderLaureate); | ||
| if (death) { | ||
| console.log(`Death: ${death.date}, ${death.place.locationString}`); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
For this exercise to work, we supposed to have additional function renderLaureates that uses forEach method on the laureates array.
The forEach method iterates over each element in the array and applies a callback function to it as follows:
function renderLaureates(laureates) {
laureates.forEach(renderLaureate);
}
| addTableRow(table, 'Birth', `${birth.date}, ${birth.place.locationString}`); | ||
| addTableRow(table, 'Death', `${death.date}, ${death.place.locationString}`); | ||
|
|
||
| const birthInfo = birth ? `${birth.date}, ${birth.place.locationString}` : 'Unknown'; |
There was a problem hiding this comment.
Same as exercise 5, we need to add en to this line 30 (${birth.place.locationString.en}) and line 33.
Can you update line 30 and 33 to look like this?
Line 30:
const birthInfo = birth ? `${birth.date}, ${birth.place.locationString.en}` : 'Unknown';Line 33:
const deathInfo = death ? `${death.date}, ${death.place.locationString.en}` : 'Unknown';There was a problem hiding this comment.
@aleksandrstarshynov This feedback wasn't implemented - exercise 6 is not working as expected.
|
|
||
| ### 3-UsingAPIs - Week2 | ||
|
|
||
| | Exercise | Passed | Failed | ESLint | |
There was a problem hiding this comment.
@aleksandrstarshynov Great job. To approve this, there are a couple of things we need to update. You can find my comments/ feedbacks for each exercise. Let me know if you have any questions.
|
@ddoyediran Thank you for your support. |
No description provided.