Ahmad_Zetouny-w2-UsignAPIs #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: .test-summary/TEST_SUMMARY.md new file: .vscode/launch.json new file: 3-UsingAPIs/Week2/test-reports/ex1-programmerFun.report.txt new file: 3-UsingAPIs/Week2/test-reports/ex2-pokemonApp.report.txt new file: 3-UsingAPIs/Week2/test-reports/ex3-rollAnAce.report.txt new file: 3-UsingAPIs/Week2/test-reports/ex4-diceRace.report.txt new file: 3-UsingAPIs/Week2/test-reports/ex5-vscDebug.report.txt new file: 3-UsingAPIs/Week2/test-reports/ex6-browserDebug.report.txt
durw4rd
approved these changes
Apr 29, 2025
| async function fetchData(url) { | ||
| const getData = await fetch(url); | ||
| if (!getData.ok) { | ||
| throw new Error('Invalid URL'); |
There was a problem hiding this comment.
There could also be other errors - for example, the API endpoint could be unresponsive. A better handling of the error would be logging the details of the response object.
| document.body.appendChild(selector); | ||
| } | ||
|
|
||
| pokemonList.map((pokemon) => { |
There was a problem hiding this comment.
Nice use of the map method.
Just FYI, most other students would use the forEach method here.
|
|
||
| selector.addEventListener('change', async () => { | ||
| try { | ||
| const data = await fetchData( |
There was a problem hiding this comment.
I would prefer if fetching the Pokémon image was handled within the fetchImage function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.