Hossein-w2-node.js #14
Conversation
Hossein-Kelisa
commented
Feb 24, 2025
Hossein-Kelisa
commented
- Connected OpenWeatherMap API to fetch weather data.
- Added error handling for missing or invalid city names.
- Wrote tests to make sure everything works correctly.
There was a problem hiding this comment.
Very well done, Hossein! You did a great job on this assignment.
I left some comments for improvement; please have a look.
There is another thing needs to be fixed; please move the files from
assignments/config-files/hackyourtemperature to assignments/hackyourtemperature.
| expect(response.status).toBe(200); | ||
| expect(response.body.weatherText).toContain('Amsterdam'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This unit-test is great, and it covers the main cases. One minor improvement to enhance readability and maintainability is to consider standardizing the code style; ensure consistent spacing, method chaining, and line breaks.
For example, line 8:
const response = await request.post('/weather').send({});
All the calls in one line, but in line 16:
const response = await request
.post('/weather')
.send({ cityName: 'aslkdjflaskjd' });
It's in multiple lines.
There was a problem hiding this comment.
You're right! I'll standardize the code for better readability and maintainability. Thanks for the tip
| } | ||
| }); | ||
|
|
||
| export { app }; |
There was a problem hiding this comment.
The code is good and functional, but the format can be improved. You could use the built-in functionality in VS Code to format the code https://code.visualstudio.com/docs/editor/codebasics#_formatting.
There was a problem hiding this comment.
Thanks for the suggestion!
| @@ -0,0 +1,5 @@ | |||
| const keys = { | |||
| API_KEY: "d19e6d84be4dc190db7e1381f4ade935" | |||
| }; | |||
There was a problem hiding this comment.
I know it is in the instructions https://github.com/HackYourAssignment/Node.js-Cohort51/blob/main/week2/MAKEME.md#311-setting-up-the-api that you have to put the key in the file. But for enhanced security, it's best practice to use environment variables. The dotenv library (https://github.com/motdotla/dotenv) facilitates this by enabling you to store sensitive information, like your API key, in a .env file, which is then loaded into the environment.
There was a problem hiding this comment.
Thanks for the security tip! I'll definitely use dotenv to store the API key in a .env file
|
Hi @eidosam I have resolved all your suggestions.Please review the updates and let me know if anything else is needed. Thanks for your feedback and for your time, |
There was a problem hiding this comment.
Thank you, @Hossein-Kelisa, for addressing the feedback! But there are still issues with the code format; could you please fix it? This document might help: https://code.visualstudio.com/docs/editor/codebasics#_formatting.
Also, the dotenv is missing from the dependencies in package.json.
|
Hi @eidosam |
