Khiro-W2-Node.js #20
Open
Khiro-W2-Node.js #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xed-euteon
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Great work,
You've made some good enough use case as required in the assignment requirements, with your clean structure you have covered key test scenarios.
One note though: you have placed your homework in the config-files lol...
Anyways, LGTM; keep it up. 🎉
Comment on lines
+3
to
+10
| import { API_KEY } from "./sources/keys.js"; | ||
| const app = express(); | ||
| app.use(express.json()); | ||
|
|
||
| app.get("/", (req, res) => { | ||
| res.send("Hello from the backend "); | ||
| }); | ||
| app.post("/weather", async (req, res) => { |
There was a problem hiding this comment.
consistent line spacing improves readability.
Comment on lines
+1
to
+3
| node_modules/ | ||
| .env | ||
| .DS_Store |
Comment on lines
+1
to
+3
| import dotenv from "dotenv"; | ||
| dotenv.config(); | ||
| export const API_KEY = process.env.API_KEY; |
Comment on lines
+23
to
+25
| if (response.status === 404) { | ||
| return res.status(404).json({ Error: "Invalid city name" }); | ||
| } else { |
There was a problem hiding this comment.
Two points:
- it's a good idea to check for the
response.okas it's not always a 404 same as not okay - you are returning, it's an early return, no need for an else statement.
Comment on lines
+6
to
+9
| "scripts": { | ||
| "test": "jest", | ||
| "start": "node server.js", | ||
| "dev": "nodemon server.js" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed the temperature app by fetching weather data from the openweathermap, accepting a city name via the POST method, and writing tests for the app.