Skip to content

Assignments week 1 Konjit #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

konjit
Copy link

@konjit konjit commented Feb 18, 2025

No description provided.

Copy link

@xed-euteon xed-euteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For only the first week, such homework is a basic setup for what comes up next, thus, I will not be giving a lot of in detail review so we just keep it as simple as possible.

LGTM; is all I can say.

keep it up. 🎉

Comment on lines +6 to +9
"scripts": {
"start": "nodemon server.js",
"dev": "node --watch server"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment on lines +15 to +17
"express": "^4.21.2",
"express-handlebars": "^8.0.1",
"node-fetch": "^3.3.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've missed nodemon no biggie though.

Comment on lines +15 to +17
if(!cityName) {
return res.status(404).json({message: "City name is required."})
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

})

app.post('/weather', (req, res) => {
const cityName = req.body.cityName;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const cityName = req.body.cityName;
const { cityName } = req.body;

@xed-euteon xed-euteon added Approved Week 1 Week 1 assignment and removed Review in progress labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Week 1 Week 1 assignment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants