-
Notifications
You must be signed in to change notification settings - Fork 11
Assignments week 1 Konjit #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For only the first week, such homework is a basic setup for what comes up next, thus, I will not be giving a lot of in detail review so we just keep it as simple as possible.
LGTM; is all I can say.
keep it up. 🎉
"scripts": { | ||
"start": "nodemon server.js", | ||
"dev": "node --watch server" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
"express": "^4.21.2", | ||
"express-handlebars": "^8.0.1", | ||
"node-fetch": "^3.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've missed nodemon
no biggie though.
if(!cityName) { | ||
return res.status(404).json({message: "City name is required."}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
}) | ||
|
||
app.post('/weather', (req, res) => { | ||
const cityName = req.body.cityName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const cityName = req.body.cityName; | |
const { cityName } = req.body; |
No description provided.