rizan-ibrahim-node.js-w1 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eidosam
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
Great job, Rizan! You did very well in this assignment, here are some good points:
- Using ES Modules is good and a modern practice.
- Proper error handling and using the correct HTTP code.
- Defining the port as a constant is good practice.
One area for improvement is adding a description to the PR to provide more context.
Keep up the good work!
| { | ||
| "name": "hackyourtemperature", | ||
| "version": "1.0.0", | ||
| "main": "index.js", |
There was a problem hiding this comment.
The main field in package.json should match the actual entry point of the application, which is server.js in this case. This tells Node.js where to start the application when using commands like node . or npm start.
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", |
There was a problem hiding this comment.
It's good practice to include the author name and public email in the author field, like this: Name <email-address>, though it's not mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.