Assignments week 2 Ilias Khugaev #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandelissym
approved these changes
May 14, 2025
| @@ -0,0 +1,5 @@ | |||
| const keys = { | |||
| API_KEY: '035094224f6afb540ccce53b0bb98609' | |||
There was a problem hiding this comment.
It is not good practice to push your api key to github as it can lead to unauthorized access to git.
A suggestion would be to add this to your .gitignore
| res.status(200).send(responseText); | ||
|
|
||
| } catch (error) { | ||
| responseText.weatherText = `${error}`; |
There was a problem hiding this comment.
A suggestion here: Like this you are passing the error object as a response string. this can be dangerous as you dont know what error is being returned. It is better to return a custom message, like Failed to retrieve data from external service and use a 502 error code (https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/502)
Pandelissym
reviewed
May 14, 2025
| request.get('/') | ||
| .expect(200, 'Hello from backend to frontend!', done) | ||
| }); | ||
| });`` |
|
Really good work at the second assignment! All the requirements are met. Nice job on integrating with the external api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.