Assignments week 1 Ahmad Zetouny #3
Conversation
Zetouny
changed the title
| import express from "express"; | ||
|
|
||
| const app = express(); | ||
| const port = 3000; |
There was a problem hiding this comment.
Constants like this are usually written in all uppercase (PORT instead of port). This is a convention that improves readability.
| }); | ||
|
|
||
| app.post("/weather", (req, res) => { | ||
| const cityName = req.body.cityName; |
There was a problem hiding this comment.
A suggestion here (non-blocking) would be to log the city name before returning it. This allows you to easily debug/see what is going on when your /weather endpoint is called. You can log whatever you want (e.g. City name: cityName or the whole body object).
|
Thank you @Pandelissym, for your time. |
I would only make port uppercase. By convention only string literals or numbers that wont be changed but are just going to stay constant at that value (only read) are uppercased. The app variable should still be lowercase 🙂 |
|
My bad, I thought you meant that variables being in the global scope should always be uppercase. 😅 |
No worries! Looks goot me now. Approved! |
No description provided.