Assignments week 1 YANA SENIUK #5
Conversation
There was a problem hiding this comment.
Very good work on the first assignment! All criteria are met and you want beyond the expectations! Good job on separating your logic into folders and modules, adding a gitignore, using environmental variables and using error handlers and middleware!
I have left a few suggestions for improvements that you can take a look at.
| const app = express(); | ||
| const PORT = process.env.PORT || 3000; | ||
|
|
||
| function main() { |
There was a problem hiding this comment.
There is no need to create a function for this and call it. You can remove the function and the call to main(). This will make your code more readable!
There was a problem hiding this comment.
This file should also be inside src as it is part of your code!
| //non-exist path | ||
| app.use(notFound); | ||
|
|
||
| //error handling |
There was a problem hiding this comment.
These comments are not necessary. Good job and trying to make the code readable but you already use very clear variable names! The comments are not adding much as it is already clear from reading the code
| "main": "server.js", | ||
| "type": "module", | ||
| "scripts": { | ||
| "start": "node --watch --env-file=.env server.js" |
There was a problem hiding this comment.
A tip here would be to create two scripts. One called dev and one called start. The dev script could then use the --watch flag and the start script without the watch flag. This seperates development from production code! You dont want to be using --watch in production as it is less performant and more dangerous!
| }); | ||
|
|
||
| //Api Routes | ||
| app.use("/api/weather", weatherRouter); |
There was a problem hiding this comment.
Adding the /api/ path is a very good practice good job! I would also move the GET / route under the /api/ path to keep things consistent as that route is also part of your api!
No description provided.