w1-assignment #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycons
requested changes
Feb 2, 2025
There was a problem hiding this comment.
Good implementation 👍
- Copied fake data into
srcfolder as instructed ✅ - Product list that displays all of the products from the
all-productsfile ✅ - Category list that displays all of the categories from the
all-categoriesfile at the top of the page ✅ - If the user clicks on a category, only the products that have that category in their category property should be displayed ✅
- Only 1 category is active at a time and the user should see which category is selected ✅
- Page is reponsive and adapts to various breakpoints ✅
Requested improvements:
- Please deploy app to netlify and and the link to the PR description.
I left some questions and a minor change, but it is not a blocker for approval.
| title: PropTypes.string.isRequired, | ||
| image: PropTypes.string.isRequired, | ||
| }) | ||
| ).isRequired, |
There was a problem hiding this comment.
Out of curiousity, what is the value of defining prop types for this component? What happens if it is not defined?
|
This requirement to deploy the app is missing from the PR. Can you add it please?
|
sycons
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.