-
Notifications
You must be signed in to change notification settings - Fork 7
Liya-w2-react #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Liya-w2-react #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Liya, there are 2 versions for src
folder and package.json
file in this PR. One is in the project
folder and the other is in the ecommerce
folder. Basically there are 2 React Apps in this PR. Can you clean this up so that there is only 1 React App and I can continue the review on that app?
Can you also add the link to the deployed app (somewher like netlify) to this PR?
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following was implemented:
fake-data
directory is no longer used ✅- App connects to endpoints in the API to fetch data for categories and products ✅
- Filter the products in the API and not in the frontend ✅
- App displays loading spinner when waiting for request to complete fetching data ✅
- App shows an error message if the request failed ✅
- Clicking on product card goes to a detail page ✅
- Detail page fetches data from an endpoint ✅
- Deploy app somewhere (like netlify) and add link to PR ✅
Compliments:
The stlying of this app is sleek and smooth. It responds beautifully for different endpoints, with the padding and the layout holding really well ⭐
Some optional changes have been suggested. These are not a blocker for approval.
Only the change requested in App.jsx
is required to approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work Liya! ⭐
I appreciate you implementing even the optional changes. The code is a lot more polished and well structured now.
No description provided.