Ruba week1 React #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ruba, Your code works well and shows a good understanding of React. Love the Product Card styling and attention to UX details ✨ Assignment Requirements ✅
Comments Rules
Suggestions 💡
Nice-to-have ✨
Praise 🌟
Nice one! |
ChingHsun
reviewed
Feb 7, 2025
week1/project/ecommerce/src/App.jsx
Outdated
| activeCategory === "All" | ||
| ? productsData | ||
| : productsData.filter((product) => { | ||
| return product.category === activeCategory.replace("FAKE: ", ""); |
There was a problem hiding this comment.
Suggested change
| return product.category === activeCategory.replace("FAKE: ", ""); | |
| return product.category === activeCategory; |
Suggestion:
.replace("FAKE: ", "") ideally be handled within ProductList.
Due to the Single Responsibility principle, The App pages shouldn't need to know the 'FAKE:' detail.
week1/project/ecommerce/src/App.jsx
Outdated
Comment on lines
18
to
19
| }); | ||
| return ( |
There was a problem hiding this comment.
Suggested change
| }); | |
| return ( | |
| }); | |
| return ( |
Nice to have:
Better to have a spare line
Comment on lines
18
to
19
| > | ||
| {category.replace("FAKE: ", "")}{" "} |
There was a problem hiding this comment.
Suggested change
| > | |
| {category.replace("FAKE: ", "")}{" "} | |
| > | |
| {category.replace("FAKE: ", "")} |
Nice to have
week1/project/ecommerce/src/App.css
Outdated
Comment on lines
111
to
124
| @keyframes logo-spin { | ||
| from { | ||
| transform: rotate(0deg); | ||
| } | ||
| to { | ||
| transform: rotate(360deg); | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: no-preference) { | ||
| a:nth-of-type(2) .logo { | ||
| animation: logo-spin infinite 20s linear; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggestion:
Removing unused files and styles that came with the project template. such as logo, and assets folder
ChingHsun
reviewed
Feb 7, 2025
| @@ -0,0 +1,26 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Suggested change
| import React from "react"; |
Suggestion:
When importing a React component, you can skip 'import React' for modern React (17+)
Reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.