Eli_D_Rajha-w2-React #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Live Netlify site for Week 2: |
|
ChingHsun
reviewed
Jul 3, 2025
week2/project/project-2/src/App.jsx
Outdated
Comment on lines
42
to
63
| <Route | ||
| path="/" | ||
| element={ | ||
| <div> | ||
| <h1>Ecommerce Shop</h1> | ||
|
|
||
| {error && <p>Error fetching data!</p>} | ||
| {loading ? ( | ||
| <p>Loading...</p> | ||
| ) : ( | ||
| <> | ||
| <CategoryList | ||
| categories={categories} | ||
| selectedCategory={selectedCategory} | ||
| onSelectCategory={setSelectedCategory} | ||
| /> | ||
| <ProductList products={products} /> | ||
| </> | ||
| )} | ||
| </div> | ||
| } | ||
| /> |
There was a problem hiding this comment.
It works fine as is, but splitting it into a MainPage component might help keep things more organized, especially as the app grows.
Comment on lines
3
to
4
| <div style={{ display: 'flex', gap: '10px', flexWrap: 'wrap', marginBottom: '20px' }}> | ||
| {categories.map((cat, index) => ( |
There was a problem hiding this comment.
I recommend using CSS Modules or Tailwind CSS instead of inline styles
week2/project/project-2/src/App.jsx
Outdated
Comment on lines
29
to
42
| fetch(url) | ||
| .then((res) => { | ||
| if (!res.ok) throw new Error('Network response was not ok'); | ||
| return res.json(); | ||
| }) | ||
| .then((data) => { | ||
| setProducts(data); | ||
| setLoading(false); | ||
| }) | ||
| .catch(() => { | ||
| setError(true); | ||
| setProducts([]); | ||
| setLoading(false); | ||
| }); |
There was a problem hiding this comment.
In this case, it is better to use finally to ensure the loading state with more readable and maintain reason
| padding: '8px 12px', | ||
| }} | ||
| > | ||
| {cat} |
There was a problem hiding this comment.
Suggested change
| {cat} | |
| {category} | |
Using category instead of cat would be a small change in length, but it greatly improves readability. Especially collaborative with team project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fakestoreapi.com/products/categories-> To get all the categorieshttps://fakestoreapi.com/productsorhttps://fakestoreapi.com/products/category/:selectedCategory-> To get the products. The API needs to do the filtering, not the frontend. Usually the amount of products will be too large to do the filtering on the frontend./product/:idwhenever you click on the product card in the list. This should get the details from the endpoint:https://fakestoreapi.com/products/<id>. For now we won't add a navigation bar, the browsers 'back' button will do the trick. TIP: You will need to add thereact-router-dompackage and add the routing to your app regardless.