YANA_SENIUK-w2-React #18
Conversation
|
I have already know my mistakes. I will fix it soon. |
|
@yanaesher How are you progressing with the next commit? I was going to start reviewing your code but if you want me to wait for your fixes then I can. Also asked in Slack. |
There was a problem hiding this comment.
Hi Yana,
Well done for quickly cleaning up the issues we discussed via Slack yesterday. Your code is organised very well! This will look impressive when showing to potential employers.
I have left a couple of comments to make your code look even more organised.
|
|
||
| const BASE_STORE_URL = "https://fakestoreapi.com"; | ||
|
|
||
| export const getAllCategories = async () => { |
| const product = await getProductById(id!); | ||
| setProduct(product); | ||
| } catch (err) { | ||
| if (err instanceof Error) setError(err.message); |
There was a problem hiding this comment.
You can do this, but it's not really necessary.
You're also excluding other error types. What happens here if there's some error that is not an instance of Error? 🔵
| @@ -0,0 +1,5 @@ | |||
| export const getFetcher = async (url: string) => { | |||
| const res = await fetch(url); | |||
| if (!res.ok) throw new Error(`Failed to fetch data: ${res.status}`); | |||
There was a problem hiding this comment.
You might want to make this a little more user-friendly - users won't understand what the status codes mean. 🔵
|
|
||
| return ( | ||
| <div className="wrapper"> | ||
| <main className="main"> |
|
|
||
| {error && <p className="text-red-500">{error}</p>} | ||
|
|
||
| {!loading && !error && categories.length > 0 && ( |
There was a problem hiding this comment.
You don't need to do the truthiness check for loading and error here. You've already verified on the previous lines that loading and error must both be falsy in order to reach this line of code. If you add in every single variable in a large application your JSX will soon become difficult to read and manage. 🟠
| @@ -0,0 +1,25 @@ | |||
| import type { Category } from "../types/category"; | |||
No description provided.